Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRN - reference revision and tests #6629

Merged
merged 14 commits into from
Jul 16, 2021
Merged

GRN - reference revision and tests #6629

merged 14 commits into from
Jul 16, 2021
+191 −56

Conversation

mitruska
Copy link
Contributor

@mitruska mitruska commented Jul 13, 2021 •
edited
Loading

Details:

GRN - reference revision and tests

GRN is a special case of NormalizeL2 (across channel) with the bias as eps
so the reference is a simple call of reference::normalize_l2 (no changes needed)

runtime/reference/grn.hpp

void grn(const T* data, T* out, float bias, const Shape& data_shape)
{
    normalize_l2(data, out, data_shape, {1}, bias, op::EpsMode::ADD);
}

In this PR:

  • Add shared single layer GRN tests instance for cpu
  • Add new template reference GRN tests (and remove legacy backend GRN fused op tests)

Tickets:

  • 44630 (45772, 45772)

@mitruska mitruska self-assigned this Jul 13, 2021
@mitruska mitruska added the category: Core OpenVINO Core (aka ngraph) label Jul 13, 2021
@mitruska mitruska marked this pull request as ready for review July 14, 2021 15:54
@mitruska mitruska requested a review from a team as a code owner July 14, 2021 15:54
@mitruska mitruska requested review from a team, ilyachur and jdanieck July 14, 2021 15:54
jdanieck
jdanieck reviewed Jul 15, 2021
View reviewed changes
Copy link
Contributor

@jdanieck jdanieck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I a missing two things:

  • serialization SLT
  • adding GRN to trusted ops

@jdanieck jdanieck added this to the 2022.1 milestone Jul 15, 2021
@mitruska
Copy link
Contributor Author

mitruska commented Jul 15, 2021 •
edited
Loading

@jdanieck

I a missing two things:

  • serialization SLT
  • adding GRN to trusted ops

Done

@mitruska mitruska requested review from jdanieck and ilyachur July 15, 2021 11:22
@ilyachur
Copy link
Contributor

@mitruska Please rerun CI

@ilyachur ilyachur self-assigned this Jul 16, 2021
@ilyachur ilyachur enabled auto-merge (squash) July 16, 2021 06:54
@ilyachur ilyachur merged commit fa8f45b into openvinotoolkit:master Jul 16, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@mitruska
GRN - reference revision and tests (openvinotoolkit#6629)
b66ef6e 
* Add GRN shared single layer test instance for CPU

* Remove GRN backend tests from fused_op.in

* Init GRN new template reference tests

* Add more bias values to GRN single layer tests

* Add more GRN template reference test cases

* Remove unused parameter from GrnParams

* Refactor GRN template referene tests and add more types

* Add anonymous namespace

* Add bf16 type to cpu single layer tests

* Add Serialization test

* Add GRN to revised ops
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@mitruska @andrei-cv
GRN - reference revision and tests (openvinotoolkit#6629)
eea99c7 
* Add GRN shared single layer test instance for CPU

* Remove GRN backend tests from fused_op.in

* Init GRN new template reference tests

* Add more bias values to GRN single layer tests

* Add more GRN template reference test cases

* Remove unused parameter from GrnParams

* Refactor GRN template referene tests and add more types

* Add anonymous namespace

* Add bf16 type to cpu single layer tests

* Add Serialization test

* Add GRN to revised ops
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@mitruska @akuporos
GRN - reference revision and tests (openvinotoolkit#6629)
e893d57 
* Add GRN shared single layer test instance for CPU

* Remove GRN backend tests from fused_op.in

* Init GRN new template reference tests

* Add more bias values to GRN single layer tests

* Add more GRN template reference test cases

* Remove unused parameter from GrnParams

* Refactor GRN template referene tests and add more types

* Add anonymous namespace

* Add bf16 type to cpu single layer tests

* Add Serialization test

* Add GRN to revised ops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdanieck jdanieck jdanieck approved these changes

@ilyachur ilyachur ilyachur approved these changes

Assignees

@ilyachur ilyachur

@mitruska mitruska

Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mitruska @ilyachur @jdanieck