Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaningful warning when nGraph Constant for initializer couldn't be created #3443

Conversation

bsledz
Copy link
Contributor

@bsledz bsledz commented Dec 2, 2020

Ticket: 41968

The previous message was unclear to the user.

@bsledz bsledz requested review from a team, tomdol and ggladilov December 2, 2020 08:25
@openvino-pushbot openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label Dec 2, 2020
Copy link
Contributor

@tomdol tomdol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in general, just one suggestion to reword a part of the message.

ngraph/frontend/onnx_import/src/core/graph.cpp Outdated Show resolved Hide resolved
@bsledz bsledz requested a review from a team December 2, 2020 09:23
@postrational postrational merged commit a493224 into openvinotoolkit:master Dec 2, 2020
@bsledz bsledz deleted the Meaningful_constant_for_initializer_warning branch December 2, 2020 12:05
evolosen pushed a commit to evolosen/openvino that referenced this pull request Dec 3, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 11, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Jan 14, 2021
jiwaszki pushed a commit to akuporos/openvino that referenced this pull request Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants