Solve warnings with PDB flags override #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake/os_flags.cmake
Outdated
| @@ -217,7 +217,7 @@ if(WIN32) | |||
| # Compiler specific flags | |||
|
|
|||
| ie_add_compiler_flags(/bigobj) | |||
| ie_add_compiler_flags(/MP) | |||
| ie_add_compiler_flags(/MP /FS) | |||
There was a problem hiding this comment.
from https://docs.microsoft.com/en-us/cpp/build/reference/fs-force-synchronous-pdb-writes?view=msvc-160:
The /MP option enables /FS by default.
There was a problem hiding this comment.
Yes, and in the same time it doesn't work as we can see in build results for commit d39f54d
openvino-pushbot
added
the
category: inference
| @@ -126,6 +126,11 @@ function(addIeTarget) | |||
| ie_developer_export_targets(${ARG_NAME} ${ARG_EXPORT_DEPENDENCIES}) | |||
| endif() | |||
| endif() | |||
| if(WIN32) | |||
| # Provide default compile pdb name equal to target name | |||
| set_target_properties(${ARG_NAME} PROPERTIES COMPILE_PDB_NAME ${ARG_NAME}) | |||
There was a problem hiding this comment.
what is PDB name by default?
There was a problem hiding this comment.
If you specify a path name that does not include a file name (the path ends in backslash), the compiler creates a .pdb file named VCx0.pdb in the specified directory.
in our case vc140.pdb for all targets, because on root level cmake we specifiy CMAKE_COMPILE_PDB_OUTPUT_DIRECTORY only
SDxKeeper
changed the title
SDxKeeper
changed the title
ilya-lavrenov
approved these changes
Nov 27, 2020
evolosen
pushed a commit
to evolosen/openvino
that referenced
this pull request
Dec 3, 2020
* resolve clash of tests compile pdb file names * Solving problem using different way * resolve duplicate flags for gtest
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 11, 2020
* resolve clash of tests compile pdb file names * Solving problem using different way * resolve duplicate flags for gtest
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
* resolve clash of tests compile pdb file names * Solving problem using different way * resolve duplicate flags for gtest
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Jan 14, 2021
* resolve clash of tests compile pdb file names * Solving problem using different way * resolve duplicate flags for gtest
jiwaszki
pushed a commit
to akuporos/openvino
that referenced
this pull request
Jan 15, 2021
* resolve clash of tests compile pdb file names * Solving problem using different way * resolve duplicate flags for gtest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to solve this issue in #3265 by setting flags on cmake level didn't work well with ninja.
This is second attempt where CMake files has been updated to remove /Zi flags and use /Z7 everywhere.