Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS layer - fix memory allocation bug #3133

Merged
merged 1 commit into from
Nov 16, 2020
Merged

NMS layer - fix memory allocation bug #3133

merged 1 commit into from
Nov 16, 2020

Conversation

andrejsokolov
Copy link
Contributor

task: -43165

@andrejsokolov andrejsokolov requested review from ggladilov, Maxim-Doronin and a user November 13, 2020 17:52
@andrejsokolov andrejsokolov requested a review from a team as a code owner November 13, 2020 17:52
@andrejsokolov andrejsokolov self-assigned this Nov 13, 2020
@andrejsokolov andrejsokolov added this to the 2021.2 milestone Nov 13, 2020
@andrejsokolov andrejsokolov added bug Something isn't working category: VPU labels Nov 13, 2020
@andrejsokolov andrejsokolov force-pushed the andreyso/nms_allocation_fix branch from 3cd4c46 to bb68647 Compare November 13, 2020 18:09
@andrejsokolov andrejsokolov force-pushed the andreyso/nms_allocation_fix branch from bb68647 to b913fb3 Compare November 16, 2020 08:53
@andrejsokolov
Copy link
Contributor Author

@Maxim-Doronin, @gladilov-gleb, please take a look

@andrejsokolov
Copy link
Contributor Author

@rvyunov, please take a look at the PR.

ggladilov
ggladilov approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@ggladilov ggladilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect to have some tests since it's a bug fix

@andrejsokolov
Copy link
Contributor Author

I'd expect to have some tests since it's a bug fix

hard to reproduce without a network.

@andrejsokolov
Copy link
Contributor Author

@Maxim-Doronin, could we merge it?

@Maxim-Doronin Maxim-Doronin merged commit 1fd0766 into openvinotoolkit:master Nov 16, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Nov 17, 2020
@andrejsokolov @mryzhov
[IE][VPU]: NMS - fix memory allocation bug (openvinotoolkit#3133)
696e0a7
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
@andrejsokolov @mryzhov
[IE][VPU]: NMS - fix memory allocation bug (openvinotoolkit#3133)
c70337d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvyunov rvyunov rvyunov approved these changes

@Maxim-Doronin Maxim-Doronin Maxim-Doronin approved these changes

@ggladilov ggladilov ggladilov approved these changes

Assignees

@Maxim-Doronin Maxim-Doronin

@andrejsokolov andrejsokolov

Labels
bug Something isn't working
Projects
None yet
Milestone
2021.2
Development

Successfully merging this pull request may close these issues.
4 participants
@andrejsokolov @ggladilov @Maxim-Doronin @rvyunov