Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ApplyPermutations for the case when more then 1 input with permutes #3095

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

mvafin
Copy link
Contributor

@mvafin mvafin commented Nov 12, 2020

Description: Shape permute was doing shape inference on the end of permutation, but if the node has other input with permute shape inference will fail.
JIRA: #39674

@mvafin mvafin requested review from rkazants, jane-intel and a team November 12, 2020 10:14
@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label Nov 12, 2020
@mvafin mvafin force-pushed the fix/permutes branch 3 times, most recently from a54d772 to 6c26433 Compare November 13, 2020 11:18
Copy link
Contributor

@jane-intel jane-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please reuse shape_of_sub_graph_reinference method to perform this.

@lazarevevgeny
Copy link
Contributor

please reuse shape_of_sub_graph_reinference method to perform this.

Are we sure that Maxim's fix is for operations which get input from ShapeOf operations since the shape_of_sub_graph_reinference re-calculates shapes for them only?

@lazarevevgeny lazarevevgeny merged commit a991ad9 into openvinotoolkit:master Nov 17, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Nov 17, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
@mvafin mvafin deleted the fix/permutes branch February 9, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants