Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IE TESTS] Remove extra dependency from Shared lib #3006

Merged
merged 7 commits into from
Nov 16, 2020
Merged

[IE TESTS] Remove extra dependency from Shared lib #3006

merged 7 commits into from
Nov 16, 2020

Conversation

iefode
Copy link
Contributor

@iefode iefode commented Nov 6, 2020

No description provided.

@iefode iefode added category: IE Tests OpenVINO Test: plugins and common category: build OpenVINO cmake script / infra labels Nov 6, 2020
@iefode iefode requested review from ilya-lavrenov, mikhail-treskin and a team November 6, 2020 10:17
@iefode iefode self-assigned this Nov 6, 2020
@openvino-pushbot openvino-pushbot added the category: inference OpenVINO Runtime library - Inference label Nov 6, 2020
@iefode iefode force-pushed the configure_skip_tests branch from a731032 to c821596 Compare November 6, 2020 11:14
@ilya-lavrenov ilya-lavrenov added this to the 2021.2 milestone Nov 6, 2020
ilyachur
ilyachur approved these changes Nov 6, 2020
View reviewed changes
cmake/features.cmake Outdated Show resolved Hide resolved
@mikhail-treskin
Copy link

We had a discussion with @iefode regarding the approach of skipping tests - using a command-line argument or cmake option.
Here is PR #2707 where different implementation is proposed (along with OPs report generation).
@ilya-lavrenov @ilyachur what are your thoughts regarding which one looks more applicable?

@ilyachur
Copy link
Contributor

ilyachur commented Nov 9, 2020

We had a discussion with @iefode regarding the approach of skipping tests - using a command-line argument or cmake option.
Here is PR #2707 where different implementation is proposed (along with OPs report generation).
@ilya-lavrenov @ilyachur what are your thoughts regarding which one looks more applicable?

From my point of view PR #2707 looks better, because we don't need to rebuild binaries in order to run skipped tests. It save a time and more conveniently for CI.

@iefode iefode changed the title [IE TESTS][IE CMAKE] Add cmake option for configuration to skip tests [IE TESTS] Remove extra dependency from Shared lib Nov 9, 2020
@azhogov
Copy link

azhogov commented Nov 16, 2020

CI passed: https://openvino-ci.intel.com/job/private-ci/job/gitlab_precommit/17596/

@azhogov azhogov merged commit e9de4da into openvinotoolkit:master Nov 16, 2020
@iefode iefode deleted the configure_skip_tests branch November 16, 2020 19:29
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Nov 17, 2020
@iefode @mryzhov
[IE TESTS] Remove extra dependency from Shared lib (openvinotoolkit#3006
995d179 
)

* [IE TESTS][IE CMAKE] Add cmake option for configuration to skip tests

* [IE TESTS] Remove extra dependency from IE tests shared lib

* Revert to add flag
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
@iefode @mryzhov
[IE TESTS] Remove extra dependency from Shared lib (openvinotoolkit#3006
7a4f30c 
)

* [IE TESTS][IE CMAKE] Add cmake option for configuration to skip tests

* [IE TESTS] Remove extra dependency from IE tests shared lib

* Revert to add flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyachur ilyachur ilyachur approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@mikhail-treskin mikhail-treskin Awaiting requested review from mikhail-treskin

Assignees

@iefode iefode

Labels
category: build OpenVINO cmake script / infra category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference
Projects
None yet
Milestone
2021.2
Development

Successfully merging this pull request may close these issues.
6 participants
@iefode @mikhail-treskin @ilyachur @azhogov @ilya-lavrenov @openvino-pushbot