Specification to ONNX external data feature #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyachur
reviewed
Nov 3, 2020
added 2 commits
November 4, 2020 10:07
added 2 commits
November 9, 2020 11:28
ilyachur
approved these changes
Nov 9, 2020
postrational
suggested changes
Nov 10, 2020
Co-authored-by: Michał Karzyński <[email protected]>
ilyachur
reviewed
Nov 11, 2020
Co-authored-by: Michał Karzyński <[email protected]>
ilyachur
approved these changes
Nov 16, 2020
avladimi
reviewed
Nov 16, 2020
docs/IE_DG/ONNX_Support.md
Outdated
| Unsupported types of tensors: | ||
| **Weights saved in external files:** | ||
|
|
||
| OpenVINO™ supports ONNX models which use weights saved in external files. It is especially useful for models larger than 2GB because of protobuf limitations. |
There was a problem hiding this comment.
Suggested change
| OpenVINO™ supports ONNX models which use weights saved in external files. It is especially useful for models larger than 2GB because of protobuf limitations. | |
| OpenVINO™ supports ONNX models that use weights saved in external files. It is especially useful for models larger than 2GB because of protobuf limitations. |
There was a problem hiding this comment.
You can also say "that store weights in external files"
docs/IE_DG/ONNX_Support.md
Outdated
| **Weights saved in external files:** | ||
|
|
||
| OpenVINO™ supports ONNX models which use weights saved in external files. It is especially useful for models larger than 2GB because of protobuf limitations. | ||
| If you want to read such model you should use `ReadNetwork` overload which takes `modelPath` as input parameter (both `std::string` and `std::wstring`). |
There was a problem hiding this comment.
Suggested change
| If you want to read such model you should use `ReadNetwork` overload which takes `modelPath` as input parameter (both `std::string` and `std::wstring`). | |
| To read such model, use the `ReadNetwork` overload that takes `modelPath` as an input parameter (both `std::string` and `std::wstring`). |
There was a problem hiding this comment.
"such models" or "such a model"
postrational
approved these changes
Nov 16, 2020
Co-authored-by: Anastasiya Ageeva <[email protected]>
avladimi
approved these changes
Nov 16, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Nov 17, 2020
* Added external weights files doc * review remarks * review remarks * review remarks Co-authored-by: Michał Karzyński <[email protected]> * review remarks. part 2 Co-authored-by: Michał Karzyński <[email protected]> * fixed info about nullptr * Apply suggestions from code review Co-authored-by: Anastasiya Ageeva <[email protected]> * review remarks. part 2 Co-authored-by: Michał Karzyński <[email protected]> Co-authored-by: Anastasiya Ageeva <[email protected]>
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
* Added external weights files doc * review remarks * review remarks * review remarks Co-authored-by: Michał Karzyński <[email protected]> * review remarks. part 2 Co-authored-by: Michał Karzyński <[email protected]> * fixed info about nullptr * Apply suggestions from code review Co-authored-by: Anastasiya Ageeva <[email protected]> * review remarks. part 2 Co-authored-by: Michał Karzyński <[email protected]> Co-authored-by: Anastasiya Ageeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.