Reference Implementation of ROIPooling op #2903

ggalieroc-zz · 2020-10-29T17:03:59Z

Overview:

Update specification
Develop ROIPooling reference implementation
Add reference implementation to int_executable
Add unit tests
Create single layer test class
Instantiate single layer tests for CPU and Myriad plugins

ticket: 37530

iefode · 2020-10-30T09:22:45Z

Please, take Single Layer test from PR, refactor this if it will be necessary and instantiate for CPU plugin

docs/ops/detection/ROIPooling_1.md

… coordinates

…ain int

docs/ops/detection/ROIPooling_1.md

ngraph/core/include/ngraph/op/roi_pooling.hpp

…pe to plain int" This reverts commit d49cfa8.

…it test

pelszkow · 2020-11-05T13:54:08Z

ngraph/core/reference/include/ngraph/runtime/reference/roi_pooling.hpp

+
+                const int num_rois = rois_shape[0];
+
+                for (unsigned int i = 0; i < shape_size(output_shape); i++)


This looks like std::fill_n.

ngraph/core/reference/include/ngraph/runtime/reference/roi_pooling.hpp

inference-engine/tests/functional/plugin/shared/include/single_layer_tests/roi_pooling.hpp

…lements

lazarevevgeny

The main comment is that the shape inference function must be more specific and try to calculate output shape even if some of the input dimensions are dynamic.

inference-engine/src/legacy_api/src/ie_cnn_layer_builder_ngraph.cpp

inference-engine/tests/functional/plugin/shared/src/single_layer_tests/roi_pooling.cpp

ngraph/test/type_prop/roi_pooling.cpp

ngraph/core/src/op/roi_pooling.cpp

…tests

lazarevevgeny

The spec changes and partial inference function LGTM.

ngraph/core/include/ngraph/op/roi_pooling.hpp

inference-engine/tests/ngraph_functions/src/roi_pooling.cpp

ngraph/core/reference/include/ngraph/runtime/reference/roi_pooling.hpp

* ROIPooling: Specification and op class alignment * ROIPooling: Add check to input tensor type to be aligned with spec * ROIPooling: Corrected spec description for input tensor shape and box coordinates * ROIPooling: Changed attributes pooled_h and pooled_w from Shape to plain int * Revert "ROIPooling: Changed attributes pooled_h and pooled_w from Shape to plain int" This reverts commit d49cfa8. * ROIPooling: Further specification changes * ROIPooling: Rename enum class ROIPoolingMethod methods * Fix style * ROIPooling: Draft reference implementation * ROIPooling: Adjust feature map element type to float for attribute unit test * ROIPooling: Add single layer test class * ROIPooling: Corrected output index to iterate through output tensor elements * ROIPooling: Added validation checks for input types in op constructor * ROIPooling: Add unit tests * ROIPooling: Attributes unit test changed to align with spec * ROIPooling: Add check for batch id in reference implementation and unit test * ROIPooling: Refactor single layer test class * ROIPooling: Add test for invalid pooling method * ROIPooling: Clean up unnecessary function declaration * ROIPooling: Remove duplicated default ROIPooling method in op constructors * ROIPooling: Add Infer method to generate suitable ROI data * ROIPooling: CPU single layer test instantiation for max method * ROIPooling: Remove enum class ROIPoolingMethod * Revert "ROIPooling: Clean up unnecessary function declaration" This reverts commit 074b540. * ROIPooling: Refactor single layer tests after removing enum class ROIPoolingMethod * ROIPooling: Add attribute checks in op constructor to align with spec and unit tests * Resolve CI failure: clang could not resolve static conversion from uint64_t to size_t * ROIPooling: Fix for output index calculation to loop through all ROIs * ROIPooling: Add unit test for bilinear interpolation method * ROIPooling: Add CPU single layer test instantiation for bilinear method * ROIPooling: Clean up unnecessary enum class for pooling method * ROIPooling: Add myriad single layer test instantiation * ROIPooling: Add F16 precision single layer tests for CPU plugin * ROIPooling: Add node validation check for string method attribute in constructor and unit tests * ROIPooling: Spec changes to improve understanding of the operation * ROIPooling: Fix for bilinear method when pooled size is 1x1 * ROIPooling: Add unit test for bilinear method and pooled size 1x1 * ROIPooling: Fix to broken format of specifications * ROIPooling: Disable Myriad single layer tests * ROIPooling: Handle dynamic dims and ranks for input tensors and unit tests * ROIPooling: Code clean up * ROIPooling: Address review comments * ROIPooling: Changed location for makeROIPooling helper method Co-authored-by: Kirill Molchanov <[email protected]>

ROIPooling: Specification and op class alignment

53a01ad

ggalieroc-zz requested review from postrational, ilyachur, asuhov, iefode, tomdol, jane-intel and pszmel October 29, 2020 17:04

ggalieroc added 2 commits October 30, 2020 16:28

ROIPooling: Add check to input tensor type to be aligned with spec

6c9154a

Merge remote-tracking branch 'upstream/master' into roi_pooling_ref_impl

b6e2520

lazarevevgeny reviewed Nov 2, 2020

View reviewed changes

docs/ops/detection/ROIPooling_1.md Outdated Show resolved Hide resolved

lazarevevgeny suggested changes Nov 2, 2020

View reviewed changes

docs/ops/detection/ROIPooling_1.md Outdated Show resolved Hide resolved

ggalieroc added 3 commits November 3, 2020 10:50

ROIPooling: Corrected spec description for input tensor shape and box…

4de40dc

… coordinates

ROIPooling: Changed attributes pooled_h and pooled_w from Shape to pl…

d49cfa8

…ain int

Merge remote-tracking branch 'upstream/master' into roi_pooling_ref_impl

c9e2e96

lazarevevgeny suggested changes Nov 3, 2020

View reviewed changes

docs/ops/detection/ROIPooling_1.md Outdated Show resolved Hide resolved

ngraph/core/include/ngraph/op/roi_pooling.hpp Outdated Show resolved Hide resolved

ggalieroc added 6 commits November 3, 2020 17:43

Revert "ROIPooling: Changed attributes pooled_h and pooled_w from Sha…

10cc3bd

…pe to plain int" This reverts commit d49cfa8.

ROIPooling: Further specification changes

a0ceb34

Merge remote-tracking branch 'upstream/master' into roi_pooling_ref_impl

3f11db7

ROIPooling: Rename enum class ROIPoolingMethod methods

26ff5dd

Fix style

447d428

ROIPooling: Draft reference implementation

c04232b

ggalieroc-zz mentioned this pull request Nov 4, 2020

Add single layer test for ROIPooling #2742

Closed

ggalieroc and others added 3 commits November 5, 2020 11:39

ROIPooling: Adjust feature map element type to float for attribute un…

871e93e

…it test

ROIPooling: Add single layer test class

48f3ad0

Merge remote-tracking branch 'upstream/master' into roi_pooling_ref_impl

3a7f371

pelszkow reviewed Nov 5, 2020

View reviewed changes

iefode reviewed Nov 6, 2020

View reviewed changes

inference-engine/tests/functional/plugin/shared/include/single_layer_tests/roi_pooling.hpp Show resolved Hide resolved

ROIPooling: Corrected output index to iterate through output tensor e…

a9642bb

…lements

ggalieroc added 2 commits November 23, 2020 16:45

ROIPooling: Fix to broken format of specifications

9e45e3a

ROIPooling: Disable Myriad single layer tests

2615849

ggalieroc-zz requested a review from mateusztabaka November 24, 2020 11:59

ggalieroc-zz marked this pull request as ready for review November 24, 2020 12:35

ggalieroc-zz requested a review from a team as a code owner November 24, 2020 12:35

ggalieroc-zz requested review from a team, lazarevevgeny and pelszkow November 24, 2020 12:35

lazarevevgeny suggested changes Nov 25, 2020

View reviewed changes

ggalieroc added 2 commits November 25, 2020 13:16

ROIPooling: Handle dynamic dims and ranks for input tensors and unit …

994db50

…tests

ROIPooling: Code clean up

19dceeb

ggalieroc-zz requested a review from lazarevevgeny November 25, 2020 12:35

Merge remote-tracking branch 'upstream/master' into roi_pooling_ref_impl

39744ff

lazarevevgeny approved these changes Nov 25, 2020

View reviewed changes

jdanieck self-requested a review November 26, 2020 08:57

ilyachur reviewed Nov 26, 2020

View reviewed changes

ngraph/core/include/ngraph/op/roi_pooling.hpp Show resolved Hide resolved

inference-engine/tests/ngraph_functions/src/roi_pooling.cpp Outdated Show resolved Hide resolved

ngraph/core/reference/include/ngraph/runtime/reference/roi_pooling.hpp Outdated Show resolved Hide resolved

ROIPooling: Address review comments

41fd032

ggalieroc-zz requested a review from ilyachur November 27, 2020 08:45

ilyachur approved these changes Nov 27, 2020

View reviewed changes

ggalieroc added 2 commits November 27, 2020 15:52

Merge remote-tracking branch 'upstream/master' into roi_pooling_ref_impl

2ed1e4e

ROIPooling: Changed location for makeROIPooling helper method

02e6f02

jdanieck removed their request for review November 27, 2020 16:10

ilyachur merged commit ac8a39d into openvinotoolkit:master Nov 30, 2020

ggalieroc-zz deleted the roi_pooling_ref_impl branch November 30, 2020 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reference Implementation of ROIPooling op #2903

Reference Implementation of ROIPooling op #2903

ggalieroc-zz commented Oct 29, 2020 •

edited

Loading

iefode commented Oct 30, 2020

pelszkow Nov 5, 2020

lazarevevgeny left a comment

lazarevevgeny left a comment


		const int num_rois = rois_shape[0];

		for (unsigned int i = 0; i < shape_size(output_shape); i++)

Reference Implementation of ROIPooling op #2903

Reference Implementation of ROIPooling op #2903

Conversation

ggalieroc-zz commented Oct 29, 2020 • edited Loading

iefode commented Oct 30, 2020

pelszkow Nov 5, 2020

Choose a reason for hiding this comment

lazarevevgeny left a comment

Choose a reason for hiding this comment

lazarevevgeny left a comment

Choose a reason for hiding this comment

ggalieroc-zz commented Oct 29, 2020 •

edited

Loading