Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT FE] Added aten::logaddexp #28539

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

itsbharatj
Copy link
Contributor

Details:

Added aten::logcumsumexp

Tickets:

@itsbharatj itsbharatj requested a review from a team as a code owner January 19, 2025 18:07
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Jan 19, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Jan 19, 2025
@itsbharatj itsbharatj changed the title Logaddexp [PT FE] Added aten::logaddexp Jan 19, 2025
@rkazants rkazants linked an issue Jan 19, 2025 that may be closed by this pull request
@rkazants
Copy link
Member

build_jenkins

@itsbharatj itsbharatj requested a review from rkazants January 19, 2025 19:34
@itsbharatj
Copy link
Contributor Author

itsbharatj commented Jan 19, 2025

Can you let me know for any changes required/approve the CI request @rkazants

Thanks!

Comment on lines +28 to +30
if self.dtype:
x = x.to(self.dtype)
y = y.to(self.dtype)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this casting. It is sufficient to generate input data of required type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove and the map as well


@pytest.mark.nightly
@pytest.mark.precommit
@pytest.mark.parametrize(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add @pytest.mark.precommit_torch_export. Take a look how other operations are enabled for torch.export case.
In order to test it locally, set env var PYTORCH_TRACING_MODE=EXPORT: https://github.com/openvinotoolkit/openvino/blob/master/.github/workflows/job_pytorch_layer_tests.yml#L132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Support aten::logaddexp
3 participants