-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT FE] Add aten::logcumsumexp #28538
Open
VectorNd
wants to merge
1
commit into
openvinotoolkit:master
Choose a base branch
from
VectorNd:VectorNd/logcumsumexp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// Copyright (C) 2018-2025 Intel Corporation | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
|
||
#include "openvino/frontend/pytorch/node_context.hpp" | ||
#include "openvino/op/convert.hpp" | ||
#include "openvino/op/cum_sum.hpp" | ||
#include "openvino/op/exp.hpp" | ||
#include "openvino/op/log.hpp" | ||
#include "utils.hpp" | ||
|
||
namespace ov { | ||
namespace frontend { | ||
namespace pytorch { | ||
namespace op { | ||
|
||
using namespace ov::op; | ||
|
||
OutputVector translate_logcumsumexp(const NodeContext& context) { | ||
// aten::logcumsumexp(Tensor self, int dim) -> Tensor | ||
num_inputs_check(context, 2, 2); | ||
auto input = context.get_input(0); | ||
auto dim = context.get_input(1); | ||
|
||
// First compute exp(input) | ||
auto exp = context.mark_node(std::make_shared<v0::Exp>(input)); | ||
|
||
// Then compute cumsum of the exponentials | ||
auto cumsum = context.mark_node(std::make_shared<v0::CumSum>(exp, dim)); | ||
|
||
// Finally take log of the result | ||
auto log = context.mark_node(std::make_shared<v0::Log>(cumsum)); | ||
|
||
return {log}; | ||
} | ||
|
||
} // namespace op | ||
} // namespace pytorch | ||
} // namespace frontend | ||
} // namespace ov |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Copyright (C) 2018-2025 Intel Corporation | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
import pytest | ||
import numpy as np | ||
import torch | ||
from pytorch_layer_test_class import PytorchLayerTest | ||
|
||
|
||
class TestLogCumSumExp(PytorchLayerTest): | ||
def _prepare_input(self): | ||
return (np.random.randn(1, 3, 224, 224).astype(np.float32),) | ||
|
||
def create_model(self, axis): | ||
class aten_logcumsumexp(torch.nn.Module): | ||
def __init__(self, axis): | ||
super(aten_logcumsumexp, self).__init__() | ||
self.axis = axis | ||
|
||
def forward(self, x): | ||
return torch.logcumsumexp(x, self.axis) | ||
|
||
ref_net = None | ||
|
||
return aten_logcumsumexp(axis), ref_net, "aten::logcumsumexp" | ||
|
||
@pytest.mark.parametrize("axis", [0, 1, 2, 3, -1, -2, -3, -4]) | ||
@pytest.mark.nightly | ||
@pytest.mark.precommit | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please also enable this operation for |
||
def test_logcumsumexp(self, axis, ie_device, precision, ir_version): | ||
self._test(*self.create_model(axis), ie_device, precision, ir_version) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may have exponent explosion for large
input
elements during computation of exp^(input_el).In order to avoid this, please do the following:
max=ReduceMax(input, dim)
ln(cumsum(exp(input), dim)) = ln(exp(max) cumsum(exp(input-max), dim)) = max + ln(cumsum(exp(input-max), dim))