LSTM/GRU/RNN Sequences : support for seq_lengths input #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
itikhono
commented
Oct 23, 2020
•
itikhono
commented
- Sequences to TI transformations
- Adjust reference implementations of GRU/LSTM/RNN Seqs
- fix ngraph python API
- IR Reader unit tests
- enable ONNX importer unit tests
- fix TensorIterator ref impl and tests
…e reference implemetations, add new tests
…s_to_tensor_iterator
…s_to_tensor_iterator
…s_to_tensor_iterator
…s_to_tensor_iterator
itikhono
requested review from
GlebKazantaev,
mitruska,
mbencer,
mikhail-treskin and
ilyachur
itikhono
added
category: Core
...ngine/tests/functional/plugin/cpu/shared_tests_instances/single_layer_tests/gru_sequence.cpp
Show resolved
Hide resolved
mikhail-treskin
suggested changes
Nov 12, 2020
...e/tests/functional/plugin/gpu/shared_tests_instances/single_layer_tests/reverse_sequence.cpp
Outdated
Show resolved
Hide resolved
mbencer
approved these changes
Nov 12, 2020
itikhono
commented
Nov 12, 2020
mitruska
approved these changes
Nov 12, 2020
ilyachur
reviewed
Nov 13, 2020
ilyachur
approved these changes
Nov 13, 2020
.../transformations/src/transformations/op_conversions/convert_sequences_to_tensor_iterator.cpp
Outdated
Show resolved
Hide resolved
.../transformations/src/transformations/op_conversions/convert_sequences_to_tensor_iterator.cpp
Show resolved
Hide resolved
GlebKazantaev
suggested changes
Nov 13, 2020
.../transformations/src/transformations/op_conversions/convert_sequences_to_tensor_iterator.cpp
Outdated
Show resolved
Hide resolved
| body_params.push_back(aggregated_Y_h_body_param); | ||
|
|
||
| // Create mask node deciding whether or not to mask batch data. | ||
| ngraph::Output<ngraph::Node> batch_seq_length = ngraph::builder::opset1::legacy_broadcast_for_binary_operation( |
There was a problem hiding this comment.
If you create opset5 operations during transformation then you can't create opset1.
There was a problem hiding this comment.
@GlebKazantaev opset5 ops are aliases to opset1, for all ops in this legacy_broadcast_for_binary_operation function.
I don't want to duplicate the code of this function and don't want to upgrade the function to opset5 due to there are other places of use of this function.
This is a general problem in our code: we cannot create helper functions with a hard-coded version of the opset. It is a more complicated issue than using this function. I will open a question in our morning meeting.
There was a problem hiding this comment.
And we also allow MO to generate ops from different opsets
.../transformations/src/transformations/op_conversions/convert_sequences_to_tensor_iterator.cpp
Outdated
Show resolved
Hide resolved
.../transformations/src/transformations/op_conversions/convert_sequences_to_tensor_iterator.cpp
Show resolved
Hide resolved
.../transformations/src/transformations/op_conversions/convert_sequences_to_tensor_iterator.cpp
Outdated
Show resolved
Hide resolved
.../transformations/src/transformations/op_conversions/convert_sequences_to_tensor_iterator.cpp
Show resolved
Hide resolved
.../transformations/src/transformations/op_conversions/convert_sequences_to_tensor_iterator.cpp
Show resolved
Hide resolved
itikhono
force-pushed
the
itikhono/sequences_to_tensor_iterator
branch
from
680e2cc to
5014cf2
Compare
mikhail-treskin
approved these changes
Nov 14, 2020
…s_to_tensor_iterator
GlebKazantaev
approved these changes
Nov 16, 2020
|
@itikhono please resolve conflicts. |
…s_to_tensor_iterator
…s_to_tensor_iterator
…s_to_tensor_iterator
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Nov 17, 2020
…it#2788) * sequences to ti transformations, support for seq_lengths input, update reference implemetations, add new tests * fix python api, update sequences to ti transformation * fix sequences to ti transformation * Update sequences to TI transformation: fix reverse sequence support * update single layer tests, fix TI reference impl, fix Sequences to TI transformations * ngraph code style * fix build * fix ngraph python api * resolver review comments, refactoring * Resolve review remarks * delete xfail
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
…it#2788) * sequences to ti transformations, support for seq_lengths input, update reference implemetations, add new tests * fix python api, update sequences to ti transformation * fix sequences to ti transformation * Update sequences to TI transformation: fix reverse sequence support * update single layer tests, fix TI reference impl, fix Sequences to TI transformations * ngraph code style * fix build * fix ngraph python api * resolver review comments, refactoring * Resolve review remarks * delete xfail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.