-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PyOV] Fix several issues with wheel building dependencies #27752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Python API
OpenVINO Python bindings
category: dependency_changes
Pull requests that update a dependency file
labels
Nov 26, 2024
almilosz
reviewed
Nov 26, 2024
akuporos
approved these changes
Nov 26, 2024
almilosz
approved these changes
Nov 27, 2024
This reverts commit db5584c.
…into wheel_deps Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
This reverts commit c591916. Signed-off-by: p-wysocki <[email protected]>
praasz
approved these changes
Dec 3, 2024
Signed-off-by: p-wysocki <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: dependency_changes
Pull requests that update a dependency file
category: Python API
OpenVINO Python bindings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
packaging
is a dependency ofsetuptools
. When installed with version lower than 22.0 it results inTypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'
when building wheel.setuptools
claims it's an expected behavior, does not enforce that constraint and recommends to add the constraint ourselves. More information: [BUG] TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero' pypa/setuptools#4483ImportError: cannot import name 'splat' from 'jaraco.functools'
has been fixed insetuptools==75.4.0
. More information: pypa/setuptools@8d518afFailed to detect ABI Tag via setuptools.command.bdist_wheel
- the functionality has been added insetuptools==70.1.0
, that's where the new lower bound comes from. More context: https://github.com/openvinotoolkit/openvino/blob/master/src/bindings/python/wheel/CMakeLists.txt#L15Tickets: