[nGraph][IE] Enable FP64 data type in IE and review nGraph Python tests #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiwaszki
added
category: inference
jiwaszki
requested review from
postrational,
ilyachur,
mbencer,
tomdol,
tsocha and
a team
ilyachur
reviewed
Oct 7, 2020
There was a problem hiding this comment.
It is hard to review because you changed the code style for all file.
In general if you add a new precision to the Inference Engine please also add new tests.
You can use this PR as an example: https://github.com/openvinotoolkit/openvino/pull/1297/files
tsocha
suggested changes
Oct 7, 2020
postrational
approved these changes
Oct 8, 2020
|
Should be @akuporos What do you think? |
jiwaszki
force-pushed
the
jiwaszki/fp64_xfail_part_fix
branch
from
e534e20 to
fa62920
Compare
added 2 commits
October 9, 2020 15:06
ilyachur
reviewed
Oct 12, 2020
inference-engine/ie_bridges/python/src/openvino/inference_engine/constants.pyx
Outdated
Show resolved
Hide resolved
| @@ -382,6 +382,9 @@ CNNLayer::Ptr NodeConverter<ngraph::op::Convert>::createLayer(const std::shared_ | |||
| case Precision::FP32: | |||
| precision_str = "FP32"; | |||
| break; | |||
| case Precision::FP64: | |||
There was a problem hiding this comment.
It can be done separately.
I think we can replace this switch/case to one line: precision_str = p.name();
tomdol
approved these changes
Oct 14, 2020
ilyachur
approved these changes
Oct 15, 2020
|
Please fix a CI. |
mbencer
approved these changes
Oct 21, 2020
akuporos
approved these changes
Nov 17, 2020
|
Please make CI green. |
added 2 commits
December 1, 2020 04:43
tsocha
approved these changes
Dec 1, 2020
evolosen
pushed a commit
to evolosen/openvino
that referenced
this pull request
Dec 3, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 11, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Jan 14, 2021
jiwaszki
pushed a commit
to akuporos/openvino
that referenced
this pull request
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.