[GPU] GroupNormalization opt kernels #25417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-ddykim
force-pushed
the
gpu-sd_group_norm
branch
3 times, most recently
from
236ed6b to
bd8702a
Compare
e-ddykim
force-pushed
the
gpu-sd_group_norm
branch
from
bd8702a to
98bd39c
Compare
yeonbok
reviewed
Jul 8, 2024
| @@ -294,6 +296,8 @@ void TransformationsPipeline::apply(std::shared_ptr<ov::Model> func) { | |||
| return !is_type<ov::op::v0::MatMul>(next_node); | |||
| }); | |||
|
|
|||
| manager.register_pass<ov::intel_gpu::GroupNormComposition>(); | |||
There was a problem hiding this comment.
GroupNormDecomposition is being disabled, but still need Composition too?
There was a problem hiding this comment.
Current OV stable diffusion models does not have group_normalization layers. They have decomposed group_normalization layers instead. So we need a composition pass to apply group_normalization in the current OV SD models.
yeonbok
approved these changes
Jul 8, 2024
| namespace ov { | ||
| namespace intel_gpu { | ||
|
|
||
| GroupNormComposition::GroupNormComposition() { |
There was a problem hiding this comment.
- That can be a common pass.
- Are new IRs generated w/ decomposed GroupNorm?
- Rename to
GroupNormFusionto be aligned with other passes
There was a problem hiding this comment.
- Okay, I'll do it in a separate PR.
- Yes, new IRs have decomposed GroupNorm layers.
- Okay, I'll apply it too.
spran180
pushed a commit
to spran180/openvino
that referenced
this pull request
Jul 27, 2024
### Details: - This PR adds two group_normalization opt kernels, group_normalization_bfyx and group_normalization_b_fs_yx_fsv16. ### Tickets: - 144094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: