Skip to content

[PT FE] Fix issue with type alignment in aten::cat #25354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2024
Merged

[PT FE] Fix issue with type alignment in aten::cat #25354

merged 2 commits into from
Jul 4, 2024

Conversation

mvafin
Copy link
Contributor

@mvafin mvafin commented Jul 3, 2024

@mvafin mvafin requested review from mitruska and eaidova July 3, 2024 11:09
@mvafin mvafin requested a review from a team as a code owner July 3, 2024 11:09
@mvafin mvafin requested a review from cavusmustafa July 3, 2024 11:09
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Jul 3, 2024
mitruska
mitruska reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@mitruska mitruska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the fix, is it possible to cover the issue by a unit test?

@mvafin
Copy link
Contributor Author

mvafin commented Jul 4, 2024

Thanks for providing the fix, is it possible to cover the issue by a unit test?

The main issue was due to calling get_node_share_ptr in ConvertLike arguments, which used always first output of the operation, I updated tests to cover that issue.

@mvafin mvafin enabled auto-merge July 4, 2024 09:11
@mvafin mvafin added this pull request to the merge queue Jul 4, 2024
Merged via the queue into openvinotoolkit:master with commit e732ade Jul 4, 2024
120 checks passed
@mvafin mvafin deleted the mvafin/pt_fe/fix_cat_align branch July 4, 2024 12:02
@mvafin mvafin added this to the 2024.3 milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitruska mitruska mitruska approved these changes

@eaidova eaidova eaidova approved these changes

@cavusmustafa cavusmustafa Awaiting requested review from cavusmustafa cavusmustafa is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

Assignees
No one assigned
Labels
category: PyTorch FE OpenVINO PyTorch Frontend
Projects
None yet
Milestone
2024.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mvafin @mitruska @eaidova