[HETERO] Support splitting new graph pattern for pipeline parallel and correct the number of submodels #25224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: inference
WeldonWangwang
force-pushed
the
wangwang/Fix_qwen1.5-14b-chat
branch
from
aa1e1c0 to
09c2109
Compare
WeldonWangwang
force-pushed
the
wangwang/Fix_qwen1.5-14b-chat
branch
from
67c96a4 to
7d1b5bc
Compare
WeldonWangwang
changed the title
peterchen-intel
changed the title
songbell
reviewed
Jul 5, 2024
| bool is_shapeof = ov::is_type<op::util::ShapeOfBase>(op); | ||
| if (((fused_model_op_map.find(name) != fused_model_op_map.end()) || is_shapeof) && | ||
| supported.count(name)) { | ||
| if ((!supported.count(fused_model_op_map[name]) || is_shapeof) && |
There was a problem hiding this comment.
seems this is a special case(shape of) of codes line 401 to 408?
maybe we can consider optimize in future?
There was a problem hiding this comment.
It is a problem that occurs when recursively looping through the entire graph, move shape of case to L401-L408 can not fix this issues, we will try the simpler way to optimize this API
There was a problem hiding this comment.
Please create a ticket to follow up if there is a way to make this solution more common.
songbell
approved these changes
Jul 5, 2024
ieliz
pushed a commit
to ieliz/openvino
that referenced
this pull request
Jul 5, 2024
…d correct the number of submodels (openvinotoolkit#25224) ### Details: - Fix qwen1.5-14b-chat with HETERO pipeline parallelism Add supported to patten: ``` ReadValue->Gather->Concat |------>ShapeOf(fused on other different affinity node) ->.... ``` - Correct the value of HETERO_NUMBER_OF_SUBMODELS by subtracting the number of independent submodels to reduce confusion ### Tickets: - *ticket-id*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Add supported to patten:
Tickets: