[GoodFirstIssue][OP CONFORMANCE][TEMPLATE] Added u64 support for the indices of Gather #25221

Vladislav-Denisov · 2024-06-26T08:24:06Z

Details:

Added u64 support for the indices of Gather.

Tickets:

[Good First Issue]: [OP CONFORMANCE][TEMPLATE] Fix Gather Inference test in op conformance #23545

Test is passed:

[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from conformance_Gather/ReadIRTest
[ RUN ] conformance_Gather/ReadIRTest.Inference/Op=Gather.8_Type=f32_Shape=dynamic_IR=1c727cc96123227a9fe6c3079a497fd64a04f273bff45b5ea56a3c0d577eca8e_Device=TEMPLATE_Config=()
MEM_USAGE=31860KB
[ CONFORMANCE ] Influence coefficient: 4.72987e-05
[ PLUGIN ] SubgraphBaseTest::compile_model() is started
[ PLUGIN ] SubgraphBaseTest::compile_model() is finished successfully. Duration is 0.143964s
RANGE FOR PARAMETER: Gather-8_0 start from: 0.000000 range: 8 resolution: 32 seed: 1
RANGE FOR PARAMETER: Gather-8_1 start from: 0.000000 range: 15 resolution: 1 seed: 1
[ PLUGIN ] SubgraphBaseTest::get_plugin_outputs() is started
[ PLUGIN ] SubgraphBaseTest::get_plugin_outputs() is finished successfully. Duration is 0.0288465s
[ REFERENCE ] SubgraphBaseTest::calculate_refs() is started
[ REFERENCE ] Calculate reference in runtime
[ REFERENCE ] SubgraphBaseTest::calculate_refs() is started
[ REFERENCE ] SubgraphBaseTest::calculate_refs() is finished successfully. Duration is 0.0094897s
[ REFERENCE ] SubgraphBaseTest::calculate_refs() is finished successfully. Duration is 0.0109919s
[ COMPARATION ] ov_tensor_utils.hpp::compare() is started
[ COMPARATION ] ov_tensor_utils.hpp::compare() is finished successfully. Duration is 0.0071786s
RANGE FOR PARAMETER: Gather-8_0 start from: 0.000000 range: 8 resolution: 32 seed: 1
RANGE FOR PARAMETER: Gather-8_1 start from: 0.000000 range: 15 resolution: 1 seed: 1
[ PLUGIN ] SubgraphBaseTest::get_plugin_outputs() is started
[ PLUGIN ] SubgraphBaseTest::get_plugin_outputs() is finished successfully. Duration is 0.0033599s
[ REFERENCE ] SubgraphBaseTest::calculate_refs() is started
[ REFERENCE ] Calculate reference in runtime
[ REFERENCE ] SubgraphBaseTest::calculate_refs() is started
[ REFERENCE ] SubgraphBaseTest::calculate_refs() is finished successfully. Duration is 0.0086416s
[ REFERENCE ] SubgraphBaseTest::calculate_refs() is finished successfully. Duration is 0.0105932s
[ COMPARATION ] ov_tensor_utils.hpp::compare() is started
[ REFERENCE ] SubgraphBaseTest::calculate_refs() is finished successfully. Duration is 0.010214s
[ COMPARATION ] ov_tensor_utils.hpp::compare() is started
[ COMPARATION ] ov_tensor_utils.hpp::compare() is finished successfully. Duration is 0.0082425s
[ OK ] conformance_Gather/ReadIRTest.Inference/Op=Gather.8_Type=f32_Shape=dynamic_IR=1c727cc96123227a9fe6c3079a497fd64a04f273bff45b5ea56a3c0d577eca8e_Device=TEMPLATE_Config=() (381 ms)
[----------] 1 test from conformance_Gather/ReadIRTest (383 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (435 ms total)
[ PASSED ] 1 test.

Vladislav-Denisov · 2024-06-26T08:24:47Z

@iefode
Hi!
Could you please review the changes?

iefode

LGTM

iefode · 2024-06-27T09:05:10Z

build_jenkins

iefode · 2024-06-27T09:07:11Z

@Vladislav-Denisov I have started the internal validation to get all failures. Could you please check the failures in Github Action jobs?

Vladislav-Denisov · 2024-06-27T11:32:07Z

@iefode I found the following information in the logs. The Gather operation is not mentioned in the failed tests. I'm not sure if my changes could have affected these tests. It looks like a sporadic case. What do you think?

C++ unit tests / C++ unit tests

[ RUN      ] ov_infer_request/ov_infer_request_test.infer_async_wait_for_return_busy/0
src/bindings/c/tests/ov_infer_request_test.cpp:364: Failure
Expected equality of these values:
  ov_status_e::REQUEST_BUSY
    Which is: -8
  ov_infer_request_get_tensor(infer_request, in_tensor_name, &input_tensor)
    Which is: 0
[  FAILED  ] ov_infer_request/ov_infer_request_test.infer_async_wait_for_return_busy/0, where GetParam() = "CPU" ([302](https://github.com/openvinotoolkit/openvino/actions/runs/9676150892/job/26697166279?pr=25221#step:29:303)0 ms)

iGPU Tests (func) / GPU

[14037/31674] smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU (846 ms)
Note: Google Test filter = smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest
[ RUN      ] smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU

MEM_USAGE=119212KB

Expected: 0.0278244 Actual: 0.0278168 Coordinate: 13 Diff: 7.62939e-06 calculated_abs_threshold: 2.90165e-06 abs_threshold: 1.19209e-07 rel_threshold: 0.0001
src/tests/functional/shared_test_classes/src/base/ov_subgraph.cpp:95: Failure
[ COMPARATION ] COMPARATION IS FAILED! incorrect elem counter: 1 among 64 shapes.
[  FAILED  ] smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU, where GetParam() = ({ ({}, { { 2, 8, 20, 20 } }) }, { 2, 4 }, 2, 2, 1, 2, "avg", "half_pixel_for_nn", f32, "GPU") (403 ms)
[----------] 1 test from smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest (403 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (405 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU, where GetParam() = ({ ({}, { { 2, 8, 20, 20 } }) }, { 2, 4 }, 2, 2, 1, 2, "avg", "half_pixel_for_nn", f32, "GPU")

 1 FAILED TEST
[14037/31674] smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU returned with exit code 1 (846 ms)

iefode · 2024-06-28T12:37:15Z

@iefode I found the following information in the logs. The Gather operation is not mentioned in the failed tests. I'm not sure if my changes could have affected these tests. It looks like a sporadic case. What do you think?

C++ unit tests / C++ unit tests

[ RUN      ] ov_infer_request/ov_infer_request_test.infer_async_wait_for_return_busy/0
src/bindings/c/tests/ov_infer_request_test.cpp:364: Failure
Expected equality of these values:
  ov_status_e::REQUEST_BUSY
    Which is: -8
  ov_infer_request_get_tensor(infer_request, in_tensor_name, &input_tensor)
    Which is: 0
[  FAILED  ] ov_infer_request/ov_infer_request_test.infer_async_wait_for_return_busy/0, where GetParam() = "CPU" ([302](https://github.com/openvinotoolkit/openvino/actions/runs/9676150892/job/26697166279?pr=25221#step:29:303)0 ms)

iGPU Tests (func) / GPU

[14037/31674] smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU (846 ms)
Note: Google Test filter = smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest
[ RUN      ] smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU

MEM_USAGE=119212KB

Expected: 0.0278244 Actual: 0.0278168 Coordinate: 13 Diff: 7.62939e-06 calculated_abs_threshold: 2.90165e-06 abs_threshold: 1.19209e-07 rel_threshold: 0.0001
src/tests/functional/shared_test_classes/src/base/ov_subgraph.cpp:95: Failure
[ COMPARATION ] COMPARATION IS FAILED! incorrect elem counter: 1 among 64 shapes.
[  FAILED  ] smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU, where GetParam() = ({ ({}, { { 2, 8, 20, 20 } }) }, { 2, 4 }, 2, 2, 1, 2, "avg", "half_pixel_for_nn", f32, "GPU") (403 ms)
[----------] 1 test from smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest (403 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (405 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU, where GetParam() = ({ ({}, { { 2, 8, 20, 20 } }) }, { 2, 4 }, 2, 2, 1, 2, "avg", "half_pixel_for_nn", f32, "GPU")

 1 FAILED TEST
[14037/31674] smoke_TestsROIAlign_avg_hpfn/ROIAlignV9LayerTest.Inference/IS=([])_TS={(2.8.20.20)}_coordShape=(2.4)_pooledH=2_pooledW=2_spatialScale=1_poolingRatio=2_poolingMode=avg_ROIMode=half_pixel_for_nn_modelType=f32_trgDev=GPU returned with exit code 1 (846 ms)

Sounds reasonable

iefode · 2024-07-02T10:09:23Z

build_jenkins

Vladislav-Denisov · 2024-07-03T14:45:54Z

@iefode could you please relaunch jenkins jobs?
I rebased my branch to the latest master

iefode · 2024-07-03T19:40:58Z

build_jenkins

…indices of Gather (openvinotoolkit#25221) ### Details: - Added u64 support for the indices of Gather. ### Tickets: - openvinotoolkit#23545 ### Test is passed: > [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from conformance_Gather/ReadIRTest [ RUN ] conformance_Gather/ReadIRTest.Inference/Op=Gather.8_Type=f32_Shape=dynamic_IR=1c727cc96123227a9fe6c3079a497fd64a04f273bff45b5ea56a3c0d577eca8e_Device=TEMPLATE_Config=() MEM_USAGE=31860KB [ CONFORMANCE ] Influence coefficient: 4.72987e-05 [ PLUGIN ] `SubgraphBaseTest::compile_model()` is started [ PLUGIN ] `SubgraphBaseTest::compile_model()` is finished successfully. Duration is 0.143964s RANGE FOR PARAMETER: Gather-8_0 start from: 0.000000 range: 8 resolution: 32 seed: 1 RANGE FOR PARAMETER: Gather-8_1 start from: 0.000000 range: 15 resolution: 1 seed: 1 [ PLUGIN ] `SubgraphBaseTest::get_plugin_outputs()` is started [ PLUGIN ] `SubgraphBaseTest::get_plugin_outputs()` is finished successfully. Duration is 0.0288465s [ REFERENCE ] `SubgraphBaseTest::calculate_refs()` is started [ REFERENCE ] Calculate reference in runtime [ REFERENCE ] `SubgraphBaseTest::calculate_refs()` is started [ REFERENCE ] `SubgraphBaseTest::calculate_refs()` is finished successfully. Duration is 0.0094897s [ REFERENCE ] `SubgraphBaseTest::calculate_refs()` is finished successfully. Duration is 0.0109919s [ COMPARATION ] `ov_tensor_utils.hpp::compare()` is started [ COMPARATION ] `ov_tensor_utils.hpp::compare()` is finished successfully. Duration is 0.0071786s RANGE FOR PARAMETER: Gather-8_0 start from: 0.000000 range: 8 resolution: 32 seed: 1 RANGE FOR PARAMETER: Gather-8_1 start from: 0.000000 range: 15 resolution: 1 seed: 1 [ PLUGIN ] `SubgraphBaseTest::get_plugin_outputs()` is started [ PLUGIN ] `SubgraphBaseTest::get_plugin_outputs()` is finished successfully. Duration is 0.0033599s [ REFERENCE ] `SubgraphBaseTest::calculate_refs()` is started [ REFERENCE ] Calculate reference in runtime [ REFERENCE ] `SubgraphBaseTest::calculate_refs()` is started [ REFERENCE ] `SubgraphBaseTest::calculate_refs()` is finished successfully. Duration is 0.0086416s [ REFERENCE ] `SubgraphBaseTest::calculate_refs()` is finished successfully. Duration is 0.0105932s [ COMPARATION ] `ov_tensor_utils.hpp::compare()` is started [ REFERENCE ] `SubgraphBaseTest::calculate_refs()` is finished successfully. Duration is 0.010214s [ COMPARATION ] `ov_tensor_utils.hpp::compare()` is started [ COMPARATION ] `ov_tensor_utils.hpp::compare()` is finished successfully. Duration is 0.0082425s [ OK ] conformance_Gather/ReadIRTest.Inference/Op=Gather.8_Type=f32_Shape=dynamic_IR=1c727cc96123227a9fe6c3079a497fd64a04f273bff45b5ea56a3c0d577eca8e_Device=TEMPLATE_Config=() (381 ms) [----------] 1 test from conformance_Gather/ReadIRTest (383 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (435 ms total) [ PASSED ] 1 test.

Vladislav-Denisov requested a review from a team as a code owner June 26, 2024 08:24

github-actions bot added the category: TEMPLATE OpenVINO Template plugin label Jun 26, 2024

sys-openvino-ci added the ExternalPR External contributor label Jun 26, 2024

iefode self-assigned this Jun 27, 2024

iefode approved these changes Jun 27, 2024

View reviewed changes

Added u64 support for the indices of Gather

1f8fe76

Vladislav-Denisov force-pushed the fix/gather branch from 96d3f04 to 1f8fe76 Compare July 3, 2024 09:40

iefode added this pull request to the merge queue Jul 6, 2024

Merged via the queue into openvinotoolkit:master with commit f1298ed Jul 6, 2024
123 checks passed

Vladislav-Denisov deleted the fix/gather branch July 8, 2024 07:57

mlukasze added this to the 2024.3 milestone Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GoodFirstIssue][OP CONFORMANCE][TEMPLATE] Added u64 support for the indices of Gather #25221

[GoodFirstIssue][OP CONFORMANCE][TEMPLATE] Added u64 support for the indices of Gather #25221

Vladislav-Denisov commented Jun 26, 2024 •

edited

Loading

Vladislav-Denisov commented Jun 26, 2024

iefode left a comment

iefode commented Jun 27, 2024

iefode commented Jun 27, 2024

Vladislav-Denisov commented Jun 27, 2024

iefode commented Jun 28, 2024

iefode commented Jul 2, 2024

Vladislav-Denisov commented Jul 3, 2024

iefode commented Jul 3, 2024

[GoodFirstIssue][OP CONFORMANCE][TEMPLATE] Added u64 support for the indices of Gather #25221

[GoodFirstIssue][OP CONFORMANCE][TEMPLATE] Added u64 support for the indices of Gather #25221

Conversation

Vladislav-Denisov commented Jun 26, 2024 • edited Loading

Details:

Tickets:

Test is passed:

Vladislav-Denisov commented Jun 26, 2024

iefode left a comment

Choose a reason for hiding this comment

iefode commented Jun 27, 2024

iefode commented Jun 27, 2024

Vladislav-Denisov commented Jun 27, 2024

iefode commented Jun 28, 2024

iefode commented Jul 2, 2024

Vladislav-Denisov commented Jul 3, 2024

iefode commented Jul 3, 2024

Vladislav-Denisov commented Jun 26, 2024 •

edited

Loading