-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPU][ARM] Fix Reduce NHWC conversion #25212
[CPU][ARM] Fix Reduce NHWC conversion #25212
Conversation
…openvino into alvoron_reduce_nhwc_fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the PR description, I guess it is not really relevant after the changes.
Also, do we have the tests which were supposed to fail before the fix? If not, shouldn't we add few?
6c1f806
to
0a269f7
Compare
0a269f7
to
1bc0707
Compare
src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/instances/arm/reduce.cpp
Outdated
Show resolved
Hide resolved
testing::ValuesIn(additionalConfig())); | ||
|
||
//There are dedicated instences of smoke_Reduce_MultiAxis_5D_CPU test in arm and x64 folders | ||
//because ACL does not support 0 as reduction axe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if the user pass 0
as the reduction axis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACL executor has not been selected and ref implementation will be used.
Details:
2 issues have been fixed
axisCast
method is updated to support NDHWC to NCDHW and vice versa conversion.Tickets: