Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU][ARM] Fix Reduce NHWC conversion #25212

Merged
merged 19 commits into from
Jul 5, 2024

Conversation

alvoron
Copy link
Contributor

@alvoron alvoron commented Jun 25, 2024

Details:

2 issues have been fixed

Tickets:

  • ticket-id

@alvoron alvoron added the platform: arm OpenVINO on ARM / ARM64 label Jun 25, 2024
@alvoron alvoron requested review from a team as code owners June 25, 2024 13:16
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jun 25, 2024
@alvoron alvoron requested a review from EgorDuplensky June 26, 2024 12:30
Copy link
Contributor

@EgorDuplensky EgorDuplensky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the PR description, I guess it is not really relevant after the changes.
Also, do we have the tests which were supposed to fail before the fix? If not, shouldn't we add few?

@alvoron alvoron force-pushed the alvoron_reduce_nhwc_fix branch from 6c1f806 to 0a269f7 Compare July 3, 2024 17:03
@alvoron alvoron force-pushed the alvoron_reduce_nhwc_fix branch from 0a269f7 to 1bc0707 Compare July 3, 2024 17:38
testing::ValuesIn(additionalConfig()));

//There are dedicated instences of smoke_Reduce_MultiAxis_5D_CPU test in arm and x64 folders
//because ACL does not support 0 as reduction axe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the user pass 0 as the reduction axis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACL executor has not been selected and ref implementation will be used.

@maxnick maxnick enabled auto-merge July 5, 2024 14:01
@maxnick maxnick added this to the 2024.3 milestone Jul 5, 2024
@maxnick maxnick added this pull request to the merge queue Jul 5, 2024
Merged via the queue into openvinotoolkit:master with commit 277c0b7 Jul 5, 2024
116 checks passed
@maxnick maxnick deleted the alvoron_reduce_nhwc_fix branch July 5, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants