New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Enable runtime buffer fusing for crop #25060

Merged

yeonbok merged 24 commits into openvinotoolkit:master from andrew-k-park:crop_runtime_buffer_fusing

Jul 5, 2024

Contributor

andrew-k-park commented Jun 17, 2024

Details:

Apply in place crop for dynamic shape at runtime

Tickets:

143096

andrew-k-park added category: GPU under_perf_check do_not_merge labels

andrew-k-park requested review from a team as code owners

June 17, 2024 08:29

andrew-k-park force-pushed the crop_runtime_buffer_fusing branch 3 times, most recently from 87011b4 to d998fe9 Compare

June 21, 2024 06:51

andrew-k-park force-pushed the crop_runtime_buffer_fusing branch 2 times, most recently from d08b063 to 3725c95 Compare

June 25, 2024 13:15

andrew-k-park removed do_not_merge under_perf_check labels

andrew-k-park added this to the 2024.3 milestone

andrew-k-park force-pushed the crop_runtime_buffer_fusing branch 4 times, most recently from be71ce3 to 2283c64 Compare

June 26, 2024 05:34

yeonbok reviewed

View reviewed changes

src/plugins/intel_gpu/src/graph/crop.cpp Outdated Show resolved Hide resolved

yeonbok reviewed

View reviewed changes

src/plugins/intel_gpu/src/graph/include/reshape_inst.h Show resolved Hide resolved

yeonbok reviewed

View reviewed changes

src/plugins/intel_gpu/src/graph/primitive_inst.cpp Outdated Show resolved Hide resolved

yeonbok reviewed

View reviewed changes

src/plugins/intel_gpu/src/graph/primitive_inst.cpp Show resolved Hide resolved

andrew-k-park force-pushed the crop_runtime_buffer_fusing branch 2 times, most recently from 6577b7f to 1620b85 Compare

June 27, 2024 09:45

yeonbok reviewed

View reviewed changes

src/plugins/intel_gpu/src/graph/graph_optimizer/prepare_buffer_fusing.cpp Outdated Show resolved Hide resolved

andrew-k-park force-pushed the crop_runtime_buffer_fusing branch 2 times, most recently from 3c09fc6 to 99c64eb Compare

June 27, 2024 23:49

andrew-k-park requested a review from yeonbok

June 28, 2024 02:32

yeonbok reviewed

View reviewed changes

src/plugins/intel_gpu/src/graph/primitive_inst.cpp Show resolved Hide resolved

yeonbok reviewed

View reviewed changes

src/plugins/intel_gpu/src/graph/graph_optimizer/prepare_buffer_fusing.cpp Show resolved Hide resolved

yeonbok reviewed

View reviewed changes

src/plugins/intel_gpu/src/graph/include/reshape_inst.h Show resolved Hide resolved

andrew-k-park added 19 commits

July 5, 2024 22:01


          rebase and apply crop axis from prim desc

67ba9d3


          code cleanup

53e3247

Signed-off-by: Andrew Park <[email protected]>


          Fix segfault for empty kernel data

f9e5a93


          Initial impl

2e92f8c


          Fix matcher failure since 2nd+ iteration

e857e54


          Fix failure for in-place crop dyn TC

f17e9b6


          Implement common function to replace WA

4dd9621


          Clean up code for condition to adjust padding and dyn pad mask

82c2ca3


          Fix failed TCs for ov_gpu_func_tests

5cb6216


          Revert "Fix failed TCs for ov_gpu_func_tests"

7a5ed37

This reverts commit 06067ce.


          update to not allow in-place crop for conv user

2feab8d

Signed-off-by: Andrew Park <[email protected]>


          follow up comments

e296315

Signed-off-by: Andrew Park <[email protected]>


          Generalize is_runtime_propagatable_padding function

ee0a2cf


          Fix accuracy issue @MiniCPM and LLaMA3

e39be1c


          Apply comments

867cfb0

Signed-off-by: Andrew Park <[email protected]>


          Do not allow to optimize out for reshape with non constant shape input

d2133f6


          Fix newly failed test cases

925c07c


          Apply comment

f8ad722


          Fix failed TCs for e2e-tests-linux-ubuntu20-layer

c5dbc77

andrew-k-park force-pushed the crop_runtime_buffer_fusing branch from 92ad9bd to c5dbc77 Compare

July 5, 2024 13:01

yeonbok added this pull request to the merge queue

Merged via the queue into openvinotoolkit:master with commit df13265

106 checks passed

yeonbok deleted the crop_runtime_buffer_fusing branch

July 5, 2024 15:49

ieliz pushed a commit to ieliz/openvino that referenced this pull request


          [GPU] Enable runtime buffer fusing for crop (openvinotoolkit#25060)

82c92d2

### Details:
 - Apply in place crop for dynamic shape at runtime

### Tickets:
 - 143096

---------

Signed-off-by: Andrew Park <[email protected]>

andrew-k-park mentioned this pull request

[GPU] Minor fixes for regression from runtime buffer fusing for crop #25454

Merged

github-merge-queue bot pushed a commit that referenced this pull request


          [GPU] Minor fixes for regression from runtime buffer fusing for crop (#…

76742a9

…25454)

### Details:
- Minor changes to fix regression issue from
#25060

### Tickets:
 - 137277

---------

Signed-off-by: Andrew Park <[email protected]>

spran180 pushed a commit to spran180/openvino that referenced this pull request


          [GPU] Minor fixes for regression from runtime buffer fusing for crop (o…

9a6b628

…penvinotoolkit#25454)

### Details:
- Minor changes to fix regression issue from
openvinotoolkit#25060

### Tickets:
 - 137277

---------

Signed-off-by: Andrew Park <[email protected]>

andrew-k-park mentioned this pull request

[GPU] Fix accuracy issue for StableDiffusion3 #26032

Merged

github-merge-queue bot pushed a commit that referenced this pull request


          [GPU] Fix accuracy issue for StableDiffusion3 (#26032)

f06365a

### Details:
- Fix accuracy issue from runtime buffer fusing for
crop(#25060)
- If user is MVN and dynamic padding exists, output padding propagation
is not supported in the base mode reshape
- oneDNN supports padded input of outer axis only for buffer fusing on
static shape

### Tickets:
 - [CVS-149472](https://jira.devtools.intel.com/browse/CVS-149472)

---------

Signed-off-by: Andrew Park <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels