[AUTO] Disable CPU model cache for fallback #24726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ywang2/disable_CPU_model_cache_for_fallback
yangwang201911
requested review from
panhaiqi,
peterchen-intel,
wangleis and
songbell
github-actions
bot
added
the
category: AUTO
songbell
reviewed
Jul 1, 2024
| (m_context->m_startup_fallback || m_context->m_runtime_fallback)) { | ||
| m_compile_context[CPU].m_device_info.config[ov::cache_dir.name()] = ""; | ||
| LOG_INFO_TAG("Clear cache dir setting for CPU accelerator"); | ||
| } |
There was a problem hiding this comment.
is it possible to move all cache related customization/operations to one function/one single entry?
we have cache operations a few lines above this change, and then some other cache operation here....
There was a problem hiding this comment.
will implement.
songbell
reviewed
Jul 5, 2024
| @@ -130,6 +130,53 @@ void AutoSchedule::init() { | |||
| m_firstload_promise.set_value(); | |||
| }); | |||
| }; | |||
| auto update_cache_setting = [this](bool is_actual_cpu, | |||
There was a problem hiding this comment.
Suggested change
| auto update_cache_setting = [this](bool is_actual_cpu, | |
| auto customize_helper_context_from_cache_setting = [this](bool is_actual_cpu, |
songbell
approved these changes
Jul 5, 2024
zhaixuejun1993
approved these changes
Jul 5, 2024
ieliz
pushed a commit
to ieliz/openvino
that referenced
this pull request
Jul 5, 2024
### Details: - Pass empty cache_dir to CPU plugin if cache_dir is set by user app when enable_startup_fallback or enable_runtime_fallback is true ### Tickets: - 141026 --------- Co-authored-by: Chen Peter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: