Respect target type in ov_add_version_defines

[lmielick]

Details:

Make ov_add_version_defines macro respect the original library type (instead of implicit assumption based on BUILD_SHARED_LIBS).
Note adding objects into a library with $<TARGET_OBJECTS:> does not work when mixing STATIC and OBJECT targets.

[ilya-lavrenov]

Object libraries are required for overcome limitation of Makefiles cmake generator, which does not support flags, definitions per source file and it leads to rebuild of everything. See #16729

See also https://stackoverflow.com/questions/39525528/trying-to-trigger-a-minimal-rebuild-with-cmake-and-set-source-files-properties

[lmielick]

Object libraries are required for overcome limitation of Makefiles cmake generator, which does not support flags, definitions per source file and it leads to rebuild of everything. See #16729

See also https://stackoverflow.com/questions/39525528/trying-to-trigger-a-minimal-rebuild-with-cmake-and-set-source-files-properties

Interesting, didn't test it with make, but Cmake accepts this implementation.

The primary problem I hit with the original implementation is that it decides to use STATIC or OBJECT library based BUILD_SHARED_LIBS, but I must use STATIC for the plugin target in either case. target_sources(${TARGET} PRIVATE $<TARGET_OBJECTS:${TARGET}_version>) does not work if ${TARGET}_version is OBJECT and ${TARGET} is STATIC.

[ilya-lavrenov]

Interesting, didn't test it with make, but Cmake accepts this implementation.

Yes, it accepts. And then cmake generates Makefiles projects, which rebuild a lot lot files when product version is changed (while actually you can pull a single commit with changes in documentation)

does not work if ${TARGET}_version is OBJECT and ${TARGET} is STATIC

Maybe you can extract target type using get_target_property(target_type ${TARGET} TYPE) and make a decision based on target_type?

[lmielick]

Maybe you can extract target type using get_target_property(target_type ${TARGET} TYPE) and make a decision based on target_type?

Yes, thought of the same. Repurposed this PR for such solution.
Can't change the branch name though.

[ilya-lavrenov]

build_jenkins

[ilya-lavrenov]

build_jenkins