Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease number of workers for ONNX Model tests to prevent OOM kills #22243

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Decrease number of workers for ONNX Model tests to prevent OOM kills #22243

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc2fd28
Decrease number of workers for ONNX Model tests to prevent OOM kills
ababushk Jan 18, 2024
14945c6
Try to use "-n auto" also
ababushk Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/job_onnx_models_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,4 +103,4 @@ jobs:
python3 -m pip install pytest-xdist[psutil] pytest-forked

- name: ONNX Models Tests
run: python3 -m pytest --backend="CPU" --model_zoo_dir="${MODELS_SHARE_PATH}" ${INSTALL_TEST_DIR}/onnx/tests/tests_python/test_zoo_models.py -v -n 12 --forked -k 'not _cuda' --model_zoo_xfail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised that it was hardcoded, it should be set to -n auto or -n logical to utilize all the available cpu cores

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto will create as many workers as number of CPU cores, right? Currently, we use 16 cores which is more than hardcoded 12

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto - all physical cores, logical - all logical cores

run: python3 -m pytest --backend="CPU" --model_zoo_dir="${MODELS_SHARE_PATH}" ${INSTALL_TEST_DIR}/onnx/tests/tests_python/test_zoo_models.py -v -n 10 --forked -k 'not _cuda' --model_zoo_xfail
Loading