Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GNA] Support timeout value set in Wait #1499

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[GNA] Support timeout value set in Wait #1499

merged 1 commit into from
Jul 28, 2020

Conversation

dorloff
Copy link
Contributor

@dorloff dorloff commented Jul 27, 2020

No description provided.

@dorloff dorloff added the category: GNA OpenVINO GNA plugin label Jul 27, 2020
@dorloff dorloff requested review from esmirno, pavel-rodionov and a team July 27, 2020 17:21
@dorloff dorloff force-pushed the gna_wait_timeout branch from 4d146ac to 70a1fc1 Compare July 28, 2020 09:56
@dorloff dorloff force-pushed the gna_wait_timeout branch from 70a1fc1 to 472dd95 Compare July 28, 2020 13:30
esmirno
esmirno reviewed Jul 28, 2020
View reviewed changes
inference-engine/src/gna_plugin/gna_plugin.cpp
@@ -957,6 +957,10 @@ uint32_t GNAPlugin::QueueInference(const InferenceEngine::BlobMap &inputs, Infer
}

bool GNAPlugin::Wait(uint32_t request_idx) {
return WaitFor(request_idx, MAX_TIMEOUT);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close to perfect - i think we can merge this way, optimal solution would be to expose wait wrapper over helper in a lambda:
see how std conditional wait designed:

template< class Predicate >
void wait( std::unique_lock<std::mutex>& lock, Predicate pred );

@asuhov asuhov merged commit 2160773 into openvinotoolkit:releases/2020/4.0.1 Jul 28, 2020
dorloff added a commit to dorloff/openvino that referenced this pull request Aug 11, 2020
@dorloff
[GNA] Support timeout value set in Wait (openvinotoolkit#1499)
5020c06
evgenytalanin-intel pushed a commit that referenced this pull request Aug 14, 2020
@dorloff @pavel-rodionov
@esmirno @ilyachur @ntyukaev @Domi2000 @ilya-lavrenov @andrew-zaytsev
Merge 2020.4.0.1 (#1764)
c880ecb 
* [GNA] Update GNA lib + propagate QoS timeout to the calling app (#1188)

* [GNA] Remove empty PWL (#1459)

* [GNA] Support timeout value set in Wait (#1499)

* [GNA] Bump GNA2 version to 1010 (#1510)

* [GNA] stored request id for completed sync infer request in order to get status later using wait() (#1458)

* stored request id for completed async infer request in order to get it's status later

* preserved status not started for multiple sequential calls to wait()

Co-authored-by: Denis Orlov <[email protected]>

* [GNA] Fix callbacks (#1607)

* [GNA] Bump GNA2 version to 1047 (#1614)

* merge documentation updates from 2020/4 branch (#1671)

* update system requirements (#1321)

* update release version in readme

* Doc Migration from Gitlab (#1289)

* Update FakeQuantize_1.md

* Update performance_benchmarks.md

* Updates graphs for FPGA

* Update performance_benchmarks.md

* Change DL Workbench structure (#1)

* Changed DL Workbench structure

* Update performance_benchmarks_faq.md

* Fixes in DL Workbench layout

* Fixes for CVS-31290

* [DL Workbench] Minor correction

* Fix for CVS-30955

* Added nGraph deprecation notice as requested by Zoe

* fix broken links in api doxy layouts

* Fixed POT TOC

* Update PAC_Configure.md

PAC DCP 1.2.1 install guide.

* Update inference_engine_intro.md

* Update opset.md

* Update VisionAcceleratorFPGA_Configure.md (#1378)

Updated from 2020.3 to 2020.4

Co-authored-by: domi2000 <[email protected]>

* Updated documentation for 2020.4 (#1434)

* Updated documentation for 2020.4

* Updated Core::ReadNetwork documentation (#1178)

Co-authored-by: Ilya Churaev <[email protected]>
Co-authored-by: Nikolay Tyukaev <[email protected]>
Co-authored-by: domi2000 <[email protected]>
Co-authored-by: Ilya Lavrenov <[email protected]>
Co-authored-by: Ilya Churaev <[email protected]>

* Documentation updates for 2020.4 (#1672) (#1729)

* Doc updates

* 2020.4 doc updates

* Removed </br> tag

* Minor fix

* Minor fixes

* Updated documentation for 2020.4 (#1434)

* Updated documentation for 2020.4

* Updated Core::ReadNetwork documentation (#1178)

* Fixed docs

Co-authored-by: Ilya Churaev <[email protected]>

Co-authored-by: Ilya Lavrenov <[email protected]>
Co-authored-by: Ilya Churaev <[email protected]>

Co-authored-by: Ilya Lavrenov <[email protected]>
Co-authored-by: Ilya Churaev <[email protected]>

Co-authored-by: Pavel Rodionov <[email protected]>
Co-authored-by: Eugene Smirnov <[email protected]>
Co-authored-by: Alexey Suhov <[email protected]>
Co-authored-by: Ilya Churaev <[email protected]>
Co-authored-by: Nikolay Tyukaev <[email protected]>
Co-authored-by: domi2000 <[email protected]>
Co-authored-by: Ilya Lavrenov <[email protected]>
Co-authored-by: Andrey Zaytsev <[email protected]>
dorloff added a commit to dorloff/openvino that referenced this pull request Aug 17, 2020
@dorloff
[GNA] Support timeout value set in Wait (openvinotoolkit#1499)
1fdb225
dorloff added a commit that referenced this pull request Aug 18, 2020
@dorloff @esmirno
Merge changes from 2020.4.0.1 (#1809)
494e9d2 
* [GNA] Propagate QoS timeout to the calling app (#1188)

* [GNA] Support timeout value set in Wait (#1499)

* [GNA] stored request id for completed sync infer request in order to get status later using wait() (#1458)

* stored request id for completed async infer request in order to get it's status later

* preserved status not started for multiple sequential calls to wait()

Co-authored-by: Denis Orlov <[email protected]>

* [GNA] Fix callbacks (#1607)

Co-authored-by: Eugene Smirnov <[email protected]>
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Aug 26, 2020
@dorloff @esmirno @mryzhov
Merge changes from 2020.4.0.1 (openvinotoolkit#1809)
38efef5 
* [GNA] Propagate QoS timeout to the calling app (openvinotoolkit#1188)

* [GNA] Support timeout value set in Wait (openvinotoolkit#1499)

* [GNA] stored request id for completed sync infer request in order to get status later using wait() (openvinotoolkit#1458)

* stored request id for completed async infer request in order to get it's status later

* preserved status not started for multiple sequential calls to wait()

Co-authored-by: Denis Orlov <[email protected]>

* [GNA] Fix callbacks (openvinotoolkit#1607)

Co-authored-by: Eugene Smirnov <[email protected]>
RomanZm pushed a commit to RomanZm/openvino that referenced this pull request Aug 28, 2020
@dorloff @esmirno
Merge changes from 2020.4.0.1 (openvinotoolkit#1809)
3772036 
* [GNA] Propagate QoS timeout to the calling app (openvinotoolkit#1188)

* [GNA] Support timeout value set in Wait (openvinotoolkit#1499)

* [GNA] stored request id for completed sync infer request in order to get status later using wait() (openvinotoolkit#1458)

* stored request id for completed async infer request in order to get it's status later

* preserved status not started for multiple sequential calls to wait()

Co-authored-by: Denis Orlov <[email protected]>

* [GNA] Fix callbacks (openvinotoolkit#1607)

Co-authored-by: Eugene Smirnov <[email protected]>
tadamowicz pushed a commit to tadamowicz/openvino that referenced this pull request Aug 30, 2023
@dorloff @esmirno @dood-apo
Merge changes from 2020.4.0.1 (openvinotoolkit#1809)
3815b46 
* [GNA] Propagate QoS timeout to the calling app (openvinotoolkit#1188)

* [GNA] Support timeout value set in Wait (openvinotoolkit#1499)

* [GNA] stored request id for completed sync infer request in order to get status later using wait() (openvinotoolkit#1458)

* stored request id for completed async infer request in order to get it's status later

* preserved status not started for multiple sequential calls to wait()

Co-authored-by: Denis Orlov <[email protected]>

* [GNA] Fix callbacks (openvinotoolkit#1607)

Co-authored-by: Eugene Smirnov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esmirno esmirno esmirno approved these changes

@pavel-rodionov pavel-rodionov Awaiting requested review from pavel-rodionov

Assignees
No one assigned
Labels
category: GNA OpenVINO GNA plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorloff @esmirno @asuhov