Load plugins strictly by absolute paths #14034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vurusovs
force-pushed
the
vu/load_plugins_by_absolute_path
branch
3 times, most recently
from
2d13d1f to
f730f8a
Compare
ilyachur
reviewed
Nov 21, 2022
|
In general LGTM, one question about shlwapi library linking. |
For security purposes load plugin libraries only by absolute path to prevent search from environment variables, working directory etc.
vurusovs
force-pushed
the
vu/load_plugins_by_absolute_path
branch
from
f730f8a to
4753557
Compare
ilyachur
approved these changes
Nov 22, 2022
Lyamin-Roman
pushed a commit
to Lyamin-Roman/openvino
that referenced
this pull request
Nov 22, 2022
For security purposes load plugin libraries only by absolute path to prevent search from environment variables, working directory etc.
This was referenced Nov 23, 2022
vurusovs
added a commit
to vurusovs/openvino
that referenced
this pull request
Nov 30, 2022
This reverts commit 97878de.
ilya-lavrenov
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Revert "Load plugin libraries safely (#14034)" This reverts commit 97878de. * Revert "Plugins absolute path loading leftovers (#14299)" This reverts commit 9ba304d. * Revert "Add `loadSOSafelyThrowIfRelativePath` test (#14311)" This reverts commit 3e9f185. * Revert "Filter out samples tests on GNA for Debian (#14195)" This reverts commit 57e630b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore LD_LIBRARY_PATH / PATH or other unsafe places for security purposes
Tickets: