Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for IsNaN operation #24420

Closed
eshoguli opened this issue May 8, 2024 · 2 comments · Fixed by #24808
Closed
Assignees
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers no_stale Do not mark as stale platform: arm OpenVINO on ARM / ARM64
Milestone

Comments

@eshoguli
Copy link
Contributor

eshoguli commented May 8, 2024

Context

JIT Emitters are part of code generation feature (a.k.a. tensor compiler) that automatically produces highly-efficient optimized fused subgraph binary code. Each emitter implements specific operation from low level OpenVINO dialect.

Prerequisites

Recommended to use ARM CPU based platform for development (e.g. Mac, Raspberry Pi etc). Emulators (e.g. QEMU) is still an option, but not that convenient, especially for final performance evaluation.

What needs to be done?

Before emitter implementation, please, modify tests to be sure that deveoped functionality is covered by test:

Tests

Tests are disabled in default build, so ensure to add -DENABLE_TESTS=ON into cmake command.

GoogleTest is used for testing. CPU functional test target is ov_cpu_func_tests. You can use two GoogleTest filters for element-wise and activation operations:

  • for element-wise operations:
./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Eltwise*"
  • for activations:
./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Activation*"

Example Pull Requests

Resources

Contact points

@eshoguli, @dmitry-gorokhov

Ticket

CVS-137700

@eshoguli eshoguli added good first issue Good for newcomers no_stale Do not mark as stale labels May 8, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues May 8, 2024
@eshoguli eshoguli added category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels May 8, 2024
@awayzjj
Copy link
Contributor

awayzjj commented May 24, 2024

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@dmitry-gorokhov dmitry-gorokhov moved this from Contributors Needed to Assigned in Good first issues May 27, 2024
@dmitry-gorokhov dmitry-gorokhov moved this from Assigned to In Review in Good first issues Jun 3, 2024
@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Jun 24, 2024
allnes pushed a commit to allnes/openvino that referenced this issue Jun 27, 2024
@mlukasze mlukasze added this to the 2024.3 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers no_stale Do not mark as stale platform: arm OpenVINO on ARM / ARM64
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants