Fixed linter errors and reduces boilerplate code for error handling#54
Merged
somm15 merged 10 commits intoopenviess:masterfrom Jan 2, 2021
Merged
Fixed linter errors and reduces boilerplate code for error handling#54somm15 merged 10 commits intoopenviess:masterfrom
somm15 merged 10 commits intoopenviess:masterfrom
Conversation
Use direct object instead of json parsing
Collaborator
Author
|
I'm more than happy to modify this PR to reflect the discussion in #52 . I'd suggest adding a exception type |
CFenner
referenced
this pull request
in CFenner/PyViCare
Dec 26, 2023
Fixed linter errors and reduces boilerplate code for error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some general cleanup.
,etc.)KeyErrorhandling by using a decoratorIndexErrorto gracefully handle one of the errors mentioned in missing info on homeassistant #51