Skip to content

Fixed linter errors and reduces boilerplate code for error handling#54

Merged
somm15 merged 10 commits intoopenviess:masterfrom
woehrl01:cleanup
Jan 2, 2021
Merged

Fixed linter errors and reduces boilerplate code for error handling#54
somm15 merged 10 commits intoopenviess:masterfrom
woehrl01:cleanup

Conversation

@woehrl01
Copy link
Copy Markdown
Collaborator

@woehrl01 woehrl01 commented Jan 1, 2021

This PR does some general cleanup.

  • Fixing of general linter errors (unused variables, unneeded escaping in regex, missing , etc.)
  • Typos in comments and readme
  • Extended readme to include information about not supported device features.
  • Removing of Macs .DS_Store files
  • Replaces a JSON parsed from a string concatenation with a direct object creation
  • Removing of duplicate method definitions to access properties.
  • Reducing boilerplate code in KeyError handling by using a decorator

@woehrl01
Copy link
Copy Markdown
Collaborator Author

woehrl01 commented Jan 2, 2021

I'm more than happy to modify this PR to reflect the discussion in #52 . I'd suggest adding a exception type PyViCareNotSupported, what do you think @oischinger, @crazyfx1, @somm15 ?

@somm15 somm15 merged commit 5fe2a23 into openviess:master Jan 2, 2021
CFenner referenced this pull request in CFenner/PyViCare Dec 26, 2023
Fixed linter errors and reduces boilerplate code for error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants