Skip to content

Add getSerial for gateways #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazyfx1 merged 3 commits into from
Feb 18, 2024
Merged

Add getSerial for gateways #354

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60aaf92
Update PyViCareGateway.py
CFenner Jan 21, 2024
531a14a
Update test_VitoconnectOpto1.py
CFenner Jan 21, 2024
5eee2b9
Apply suggestions from code review
CFenner Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions PyViCare/PyViCareGateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

class Gateway(Device):

@handleNotSupported
def getSerial(self):
return self.service.getProperty("gateway.devices")["gatewayId"]

@CFenner CFenner Jan 21, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least my Heatbox1 / VitoconnectOpto1 has no device.serial data point. I requested it in the Viessmann community but no reply so far. So I get the serial from another data point.


@handleNotSupported
def getWifiSignalStrength(self):
return self.service.getProperty("gateway.wifi")["properties"]["strength"]["value"]
4 changes: 4 additions & 0 deletions tests/test_VitoconnectOpto1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ def setUp(self):
self.service = ViCareServiceMock('response/VitoconnectOpto1.json')
self.device = Gateway(self.service)

def test_getSerial(self):
self.assertEqual(
self.device.getSerial(), "#########")
Comment thread
CFenner marked this conversation as resolved.
Outdated

def test_getWifiSignalStrength(self):
self.assertEqual(
self.device.getWifiSignalStrength(), -69)