Support for heat pumps#13
Conversation
|
I have a Vitocal 333-G BWT 331.B08 and it also works with mine. Great enhancement. |
|
Hi @somm15, any idea when you could integrate this PR and update the PyPI package? |
|
I'll have a look tonight. Sorry, I didn't receive any notification for the PR... |
|
I did merge your PR. However, I had to refactor quite a lot. 90% of the code was common with the gaz boiler.
ViCareSession is just there because of legacy and is deprecated. Naming of classes is now a little more coherent. I don't plan changing it in the future. from PyViCare.PyViCareDevice import Device In the future, I plan to make: |
* remove mypy config * add mypy config to toml * add mypy workflow * update dependency * remove request dependency * remove commented deps * add requests dependency
The current implementation of PyViCare supports only gas heatings. The ViCare API is available as well for heat pumps from Viessmann, but there are some differences in the available API methods.
This pull request does the following:
Refactoring of the ViCareSession into ViCareSession and ViCareService, where ViCareService contains the logic to access the API (this is the common code shared by gas heating and heat pumps) and the ViCareSession which contains the API methods for gas heatings. ViCareSession is 100% compatible with the previous Version.
New class ViCareHeatPumpSession which contains the API methods for heat pumps.
Would be great if you can accept this pull request and push to PyPi.org, the I will do next step by creating a pull request to https://github.com/oischinger/ha_vicare so we can support it as well in home assistant.
Code tested for heat pump only as I do not have access to a Viessmann gas heating.