-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vexctl generate #150
Merged
Merged
vexctl generate #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a function to read the golden templates to the ctl implementation Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit adds a generate() method to vexctl that generates /data from a golden templates set Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit adds the vexctl generate command. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
cpanato
requested changes
Dec 15, 2023
This commimt adds a --init flag that creates a new tempaltes directory Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
OK, I've const'd away the readme contents. PTAL @cpanato :) |
cpanato
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new subcommand to vexctl:
generate
With
vexctl generate
, users can automate the generation of VEX data from golden templates with known vex statements:The subcommand --help flag display a longer help explaining how generation works.
vexctl generate
also includes a--init
flag to scaffold a new templates directory, it writes an empty openvex document ready to append data and a README.I will follow up this PR with documentation in the examples repo.
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]