Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes extra colon delimiter before componentid #62

Closed
wants to merge 0 commits into from

Conversation

p-ssanders
Copy link
Contributor

without this change, the VEX.GenerateCanonicalID function produces a string like:

:1671745003::pkg:oci/example@sha256:47fed8868b46b060efb8699dc40e981a0c785650223e03602d8c4493fc75b68c

without this change, the VEX.GenerateCanonicalID function produces a string like:

1671745003:pkg:oci/example@sha256:47fed8868b46b060efb8699dc40e981a0c785650223e03602d8c4493fc75b68c

since the string is hashed, the extra colon delimiter changes the hash in a meaningful way.

the reason for this behavior is that the cstringFromComponent function produces a string with a leading colon, and those strings were then joined into a string with another leading colon.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cpanato cpanato requested a review from puerco September 25, 2023 11:01
@cpanato
Copy link
Member

cpanato commented Sep 25, 2023

will defer to @puerco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants