Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using log/slog instead of logrus #58

Closed
micahhausler opened this issue Sep 21, 2023 · 1 comment
Closed

Consider using log/slog instead of logrus #58

micahhausler opened this issue Sep 21, 2023 · 1 comment

Comments

@micahhausler
Copy link
Contributor

Not a specific knock on logrus, but I only found 3 log lines using logrus in this library. Can we cut this third-party import and use standard library option?

$ grep logrus -r ./*
./go.mod:	github.com/sirupsen/logrus v1.9.3
./go.sum:github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
./go.sum:github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
./pkg/vex/vex.go:	"github.com/sirupsen/logrus"
./pkg/vex/vex.go:		logrus.Warn(err)
./pkg/vex/vex.go:	logrus.Warn("vex.StatementFromID is deprecated and will be removed in an upcoming version")
./pkg/vex/functions_files.go:	"github.com/sirupsen/logrus"
./pkg/vex/functions_files.go:		logrus.Info("Abriendo CSAF")
@puerco
Copy link
Member

puerco commented Sep 23, 2023

Sounds good to me, these are mostly vestigial from the original OpenVEX poc, we have tried to remove most of the output.

micahhausler added a commit to micahhausler/go-vex that referenced this issue Sep 25, 2023
* Resolves openvex#58

Signed-off-by: Micah Hausler <[email protected]>
micahhausler added a commit to micahhausler/go-vex that referenced this issue Sep 25, 2023
* Resolves openvex#58

Signed-off-by: Micah Hausler <[email protected]>
micahhausler added a commit to micahhausler/go-vex that referenced this issue Sep 25, 2023
* Resolves openvex#58

Signed-off-by: Micah Hausler <[email protected]>
micahhausler added a commit to micahhausler/go-vex that referenced this issue Sep 25, 2023
* Resolves openvex#58

Signed-off-by: Micah Hausler <[email protected]>
micahhausler added a commit to micahhausler/go-vex that referenced this issue Sep 25, 2023
* Resolves openvex#58

Signed-off-by: Micah Hausler <[email protected]>
micahhausler added a commit to micahhausler/go-vex that referenced this issue Sep 26, 2023
* Resolves openvex#58

Signed-off-by: Micah Hausler <[email protected]>
micahhausler added a commit to micahhausler/go-vex that referenced this issue Sep 26, 2023
* Resolves openvex#58

Signed-off-by: Micah Hausler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants