refactor: migrate tests to jest #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default uses the convention of test-files being names *.test.ts. Renamed test files accordingly
Uses ts-jest
We cannot use `instanceOf Error` in jest because of jestjs/jest#2549
Jest automatically consumed and cleared calls to `console.log`. Fixed according to https://stackoverflow.com/questions/54190596/no-console-log-to-stdout-when-running-npm-test-jest
|
Another note: This PR does not yet switch from should to jests builtin assertion library, but I would also like to do that in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the tests from mocha to jest. The main reasons for this are:
Important notes for this PR:
test:quickscript. Was not really used anyway and is not possible as easily with jest.--runInBand. Jest usually runs tests in parallel to some extent but this caused race conditions due to sharedtest-openupm-clidirectory.