TEST/GTEST: Don't run sockaddr tests on bridge interfaces - #7873
Merged
yosefe merged 1 commit intoJan 27, 2022
Merged
Conversation
hoopoepg
reviewed
Jan 26, 2022
| ucs::is_rdmacm_netdev( | ||
| ifa->ifa_name)); | ||
| saddrs.back().set_port(0); /* listen on any port then update */ | ||
| if (!ucs::is_interface_usable(ifa) || is_skip_interface(ifa)) { |
Contributor
There was a problem hiding this comment.
may be check is_skip_interface first to not touch sysfs in case if iface skipped?
yosefe
force-pushed
the
topic/test-gtest-dont-run-sockaddr-tests-on
branch
from
January 26, 2022 17:47
3894ee8 to
ce6f0d7
Compare
Member
Author
|
@hoopoepg is it ok now? |
hoopoepg
approved these changes
Jan 27, 2022
dmitrygx
approved these changes
Jan 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fix test failures when docker instances run on the same machine and create temporary bridge interfaces.
How
Prevent sockaddr gtests from running on bridge interfaces