Repository navigation
UCP/RNDV: Fix in mem type pipeline - #6614
Merged
Merged
Conversation
bureddy
force-pushed
the
fix-cuda-pipeline
branch
2 times, most recently
from
April 6, 2021 20:27
d441fe9 to
1b4b0ca
Compare
yosefe
reviewed
Apr 7, 2021
| ucp_request_hdr_t sreq; /* send request on the rndv initiator side */ | ||
| uint64_t address; /* holds the address of the data buffer on the sender's side */ | ||
| size_t size; /* size of the data for sending */ | ||
| uint8_t mem_type; /* memory type */ |
Member
There was a problem hiding this comment.
we cannot change RTS header because it will break wire compatibility
need to take mem_type from unpacked remote key
Contributor
Author
There was a problem hiding this comment.
@yosefe fixed. can you please review it?
| } | ||
|
|
||
| if (!is_get_zcopy_failed) { | ||
| if (!is_get_zcopy_failed || UCP_MEM_IS_GPU(rndv_rts_hdr->mem_type)) { |
Member
There was a problem hiding this comment.
why do always need to register recv buffer in case get_zcopy failed? pls add/update the below comment
bureddy
force-pushed
the
fix-cuda-pipeline
branch
2 times, most recently
from
April 12, 2021 19:09
7ad6eb2 to
1d4e18a
Compare
bureddy
force-pushed
the
fix-cuda-pipeline
branch
from
April 14, 2021 01:32
1d4e18a to
884e7e2
Compare
yosefe
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
regression from #6208
cuda_copy ZCOPY is ignored on self endpoint because addr info is not sent because key md_map is empty.
How ?
Revert #6208
Instead of deriving the scenarios by whether the address is passed or not in the RTS, pass the memory type of source address in the RTS to make the decisions at the receiver.