Skip to content

UCT/UD: Don't wake up remote peer for every ACKREQ packet -v1.10.x #6231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosefe merged 1 commit into from
Jan 29, 2021
Merged

UCT/UD: Don't wake up remote peer for every ACKREQ packet -v1.10.x #6231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/uct/ib/ud/base/ud_ep.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1287,7 +1287,9 @@ static void uct_ud_ep_send_ack(uct_ud_iface_t *iface, uct_ud_ep_t *ep)
skb->neth->packet_type = ep->dest_ep_id;
if (uct_ud_ep_ctl_op_check(ep, UCT_UD_EP_OP_ACK_REQ)) {
skb->neth->packet_type |= UCT_UD_PACKET_FLAG_ACK_REQ;
ctl_flags |= UCT_UD_IFACE_SEND_CTL_FLAG_SOLICITED;
if (ep->tx.tick >= iface->config.min_poke_time) {
ctl_flags |= UCT_UD_IFACE_SEND_CTL_FLAG_SOLICITED;
}
}

if (uct_ud_ep_ctl_op_check(ep, UCT_UD_EP_OP_NACK)) {
Expand Down
12 changes: 12 additions & 0 deletions src/uct/ib/ud/base/ud_iface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,7 @@ UCS_CLASS_INIT_FUNC(uct_ud_iface_t, uct_ud_iface_ops_t *ops, uct_md_h md,
self->rx.quota = 0;
self->config.tx_qp_len = config->super.tx.queue_len;
self->config.peer_timeout = ucs_time_from_sec(config->peer_timeout);
self->config.min_poke_time = ucs_time_from_sec(config->min_poke_time);
self->config.check_grh_dgid = config->dgid_check &&
uct_ib_iface_is_roce(&self->super);

Expand Down Expand Up @@ -623,15 +624,26 @@ ucs_config_field_t uct_ud_iface_config_table[] = {

{"TIMEOUT", "5.0m", "Transport timeout",
ucs_offsetof(uct_ud_iface_config_t, peer_timeout), UCS_CONFIG_TYPE_TIME},

{"TIMER_TICK", "10ms", "Initial timeout for retransmissions",
ucs_offsetof(uct_ud_iface_config_t, timer_tick), UCS_CONFIG_TYPE_TIME},

{"TIMER_BACKOFF", "2.0",
"Timeout multiplier for resending trigger (must be >= "
UCS_PP_MAKE_STRING(UCT_UD_MIN_TIMER_TIMER_BACKOFF) ")",
ucs_offsetof(uct_ud_iface_config_t, timer_backoff),
UCS_CONFIG_TYPE_DOUBLE},

{"ASYNC_TIMER_TICK", "100ms", "Resolution for async timer",
ucs_offsetof(uct_ud_iface_config_t, event_timer_tick), UCS_CONFIG_TYPE_TIME},

{"MIN_POKE_TIME", "250ms",
"Minimal interval to send ACK request with solicited flag, to wake up\n"
"the remote peer in case it is not actively calling progress.\n"
"Smaller values may incur performance overhead, while extermely large\n"
"values can cause delays in presence of packet drops.",
ucs_offsetof(uct_ud_iface_config_t, min_poke_time), UCS_CONFIG_TYPE_TIME},

{"ETH_DGID_CHECK", "y",
"Enable checking destination GID for incoming packets of Ethernet network.\n"
"Mismatched packets are silently dropped.",
Expand Down
2 changes: 2 additions & 0 deletions src/uct/ib/ud/base/ud_iface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ typedef struct uct_ud_iface_config {
uct_ib_iface_config_t super;
uct_ud_iface_common_config_t ud_common;
double peer_timeout;
double min_poke_time;
double timer_tick;
double timer_backoff;
double event_timer_tick;
Expand Down Expand Up @@ -179,6 +180,7 @@ struct uct_ud_iface {
} tx;
struct {
ucs_time_t peer_timeout;
ucs_time_t min_poke_time;
unsigned tx_qp_len;
unsigned max_inline;
int check_grh_dgid;
Expand Down