Skip to content

UCP/RNDV: Fix releasing of local request ID when switching to RNDV AM (v1.10.x) - #6117

Merged
brminich merged 1 commit into
openucx:v1.10.xfrom
dmitrygx:topic/ucp/rndv_am_release_id_1_10
Jan 14, 2021
Merged

brminich merged 1 commit into
openucx:v1.10.xfrom
dmitrygx:topic/ucp/rndv_am_release_id_1_10

Conversation

@dmitrygx

Copy link
Copy Markdown
Member

What

Fix releasing of local request ID when switching to RNDV AM (backport of #6101)

Why ?

Fixes #6100 (comment)
When releasing local send request ID, need to use the rndv_rtr_hdr->sreq_id instead of rndv_rtr_hdr->rreq_id which is saved to sreq->send.msg_proto.rreq_id when switiching to RNDV AM protocol

How ?

  1. Replaced using rndv_rtr_hdr->sreq_id instead of sreq->send.msg_proto.rreq_id at the end of the function when releasing local ID.
  2. Added useful assert to compare local send request ID and ID received from a peer.

@dmitrygx

Copy link
Copy Markdown
Member Author

@yosefe can we ignore AZP failures on HWI? according to #6065, there are some issues there

@yosefe

yosefe commented Jan 13, 2021

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dmitrygx

Copy link
Copy Markdown
Member Author

@yosefe ok to merge?

@brminich
brminich merged commit 6fb6263 into openucx:v1.10.x Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants