Repository navigation
Conversation
Add supports for the following instructions: - mov $displ(%rsp), %reg64 - mov $imm32, $reg32
hoopoepg
approved these changes
Jan 6, 2021
hoopoepg
left a comment
hoopoepg
left a comment
Contributor
There was a problem hiding this comment.
what about use C bitmaps for operations, like in struct ucs_x86_cpu_version, instead of shift/mask magic?
Member
Author
IMO, C bitmaps will make it harder to understand, and if we parse each byte (e.g modrm) it is closer to the x86 instruction format specification |
Member
Author
|
bot:pipe:retest |
hoopoepg
approved these changes
Jan 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow up on #6038