Skip to content

UCT/IB: Fixes for SL selection (v1.10.x) - #6037

Merged
yosefe merged 1 commit into
openucx:v1.10.xfrom
dmitrygx:topic/uct/ib_sl_select_1_10
Dec 18, 2020
Merged

yosefe merged 1 commit into
openucx:v1.10.xfrom
dmitrygx:topic/uct/ib_sl_select_1_10

Conversation

@dmitrygx

Copy link
Copy Markdown
Member

What

Fixes for SL selection

Why ?

  1. Fixes SL (Etherhent priority) selection for RoCE devices.
  2. Fixes SL=15 selection.
  3. Covers more use cases in gtests.

How ?

  1. If the selected device has RoCE type, select SL from empty mask assuming that AR_ENABLE=no.
  2. SL mask is done for 16.
  3. Check reported string, and check different SLs instead of just 8.

Comment thread src/uct/ib/mlx5/ib_mlx5.c Resolved
@dmitrygx
dmitrygx force-pushed the topic/uct/ib_sl_select_1_10 branch from a6f32d4 to 9f8dbab Compare December 16, 2020 16:13
@dmitrygx dmitrygx changed the title UCT/IB: Fixes for SL selection UCT/IB: Fixes for SL selection (v1.10.x) Dec 16, 2020
@dmitrygx
dmitrygx force-pushed the topic/uct/ib_sl_select_1_10 branch from 9f8dbab to fed52d0 Compare December 17, 2020 05:54
@dmitrygx

Copy link
Copy Markdown
Member Author

bot:pipe:retest

@dmitrygx
dmitrygx force-pushed the topic/uct/ib_sl_select_1_10 branch from 5c27e97 to d876e26 Compare December 17, 2020 10:53
@dmitrygx

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dmitrygx

Copy link
Copy Markdown
Member Author

the failure is #6027

@dmitrygx

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dmitrygx

Copy link
Copy Markdown
Member Author

@yosefe ok to merge?

@yosefe
yosefe merged commit a4feda2 into openucx:v1.10.x Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants