Skip to content

UCS/DATASTRUCT: Add allow_list data struct - #6023

Merged
yosefe merged 1 commit into
openucx:masterfrom
gleon99:allow-list
Jan 7, 2021
Merged

UCS/DATASTRUCT: Add allow_list data struct#6023
yosefe merged 1 commit into
openucx:masterfrom
gleon99:allow-list

Conversation

@gleon99

@gleon99 gleon99 commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

What

Introduce the allow_list data struct in UCP config parser. It is based on a strings array, adding a mode, which is one of ALL, ALLOW or NEGATE.

Why ?

In order to support negation in UCX_TLS and maybe other options.

hoopoepg
hoopoepg reviewed Dec 14, 2020
View reviewed changes
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
brminich
brminich reviewed Dec 14, 2020
View reviewed changes

@brminich brminich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general comment: is it possible to unite new parser type handling with the existing array type?
(use common inline functions, etc)

Comment thread src/ucs/config/types.h Resolved
Comment thread src/ucs/config/parser.c Resolved
@gleon99

gleon99 commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 16, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@gleon99

gleon99 commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

bot:pipe:retest

@yosefe

yosefe commented Dec 16, 2020

Copy link
Copy Markdown
Member

smth is off, maybe Java exclusion broke it?

2020-12-16T09:42:29.8628129Z Configuration file(s) do(es) not support C++: /__w/1/s/.clang-format
2020-12-16T09:42:29.8647775Z error: `clang-format -lines=28:29 -lines=52:52 -lines=861:1018 -assume-filename=src/ucs/config/parser.c` failed
2020-12-16T09:42:29.8715510Z Generated patch file:
2020-12-16T09:42:29.8751911Z error: unrecognized input
2020-12-16T09:42:29.9423928Z ##[section]Finishing: Bash

@gleon99

gleon99 commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 16, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@gleon99

gleon99 commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

bot:pipe:retest

@gleon99

gleon99 commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 17, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@gleon99

gleon99 commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 17, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@gleon99

gleon99 commented Dec 30, 2020

Copy link
Copy Markdown
Contributor Author

bot:pipe:retest

yosefe
yosefe reviewed Dec 31, 2020
View reviewed changes
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
yosefe
yosefe reviewed Jan 4, 2021
View reviewed changes
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
Comment thread test/gtest/ucs/test_config.cc Resolved
yosefe
yosefe reviewed Jan 5, 2021
View reviewed changes
Comment thread src/ucs/config/parser.c Resolved
yosefe
yosefe reviewed Jan 5, 2021
View reviewed changes
Comment thread src/ucs/config/parser.c Resolved
Comment thread src/ucs/config/parser.c Resolved
@gleon99

gleon99 commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Jan 6, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

yosefe
yosefe reviewed Jan 6, 2021
View reviewed changes
Comment thread src/ucp/core/ucp_context.c Resolved
@gleon99

gleon99 commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

@yosefe - squashed.

@gleon99

gleon99 commented Jan 7, 2021

Copy link
Copy Markdown
Contributor Author

bot:pipe:retest

@yosefe
yosefe merged commit 01a0866 into openucx:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brminich brminich brminich left review comments
@yosefe yosefe yosefe approved these changes
+1 more reviewer
@hoopoepg hoopoepg hoopoepg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gleon99 @yosefe @hoopoepg @brminich