Skip to content

API/UCT: added UCT_IFACE_FLAG_EP_KEEPALIVE caps - #5951

Merged
yosefe merged 1 commit into
openucx:masterfrom
hoopoepg:topic/api-keepalive-caps
Nov 26, 2020
Merged

yosefe merged 1 commit into
openucx:masterfrom
hoopoepg:topic/api-keepalive-caps

Conversation

@hoopoepg

@hoopoepg hoopoepg commented Nov 25, 2020 •

Copy link
Copy Markdown
Contributor

What

  • added iface capability UCT_IFACE_FLAG_EP_KEEPALIVE

Why ?

  • to identify EP's which can provide keepalive functionality
    without UCX involving

How ?

  • API changed

@hoopoepg
hoopoepg requested a review from brminich November 25, 2020 13:13
@hoopoepg hoopoepg added the API label Nov 25, 2020
@hoopoepg

Copy link
Copy Markdown
Contributor Author

@tonycurtis @shamisp any comments?

Comment thread src/uct/api/uct.h Outdated
is called. */

/* Keepalive */
#define UCT_IFACE_FLAG_EP_KEEPALIVE UCS_BIT(46) /**< EP has built-in keepalive feature */

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/**< Transport endpoint has built-in keepalive feature, which guarantees the error callback on the transport interface will be called if the communication channel with remote peer is broken, even if there are no outstanding send operations */

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

- added iface capability UCT_IFACE_FLAG_EP_KEEPALIVE to
  identify EP's which can provide keepalive functionality
  without UCX involving
@hoopoepg
hoopoepg force-pushed the topic/api-keepalive-caps branch from b4120f7 to 73e2941 Compare November 25, 2020 16:32
@shamisp

shamisp commented Nov 25, 2020

Copy link
Copy Markdown
Contributor

👍

@yosefe

yosefe commented Nov 25, 2020

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@hoopoepg

Copy link
Copy Markdown
Contributor Author

@yosefe ok to approve?

@yosefe
yosefe merged commit 1506629 into openucx:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants