Repository navigation
Conversation
|
@yosefe please review |
|
Test FAILed. Build Log Test FAILed. |
|
@yosefe - can you please take a look what happened on MLNX machine ? |
|
@shamisp - you can click on link (see above "Details" and go to "Console log" |
|
@shamisp Your fix is somewhat surprising; if IB is not present, then, mlx5_hw.h header would not be present anyway. Also, you moved it from the scope of IB to the scope of RC.. |
|
RC transport would not be enabled unless IB is enabled.. if It is, it would be considered a bug in ib.m4 script |
|
I think now it is automatically detected (which is good) but the detection is broken. So this is something that I want to solve. |
|
This is the bug in M4. RC enables IB when it is not supposed to do so. |
|
The same true for dc,ud,mlx5 |
33f2761 to
72e9465
Compare
|
Test FAILed. Build Log Test FAILed. |
|
@miked-mellanox - I think my fix is ok now, but the test fails silence no transport is available it is trying to use hardcoded transport. (mlx5_0). In the #24 you solving similar issue. Feel free to merge it my patch since it seems to be function. Let me know how do we want to proceed. |
|
i think that detection logic in #22 is better and covers more cases. |
|
solved in #24 |
…ble-ucp-cleanup-i3 TEST: io_demo - fix segv due to double calling of ucp_cleanup()
RC/UD build was enabled out of the scope of IB build