Repository navigation
UCS/RCACHE: Default merging rcache regions to on - #12267
william-gallagher-nv wants to merge 1 commit into
Conversation
|
🤖 Starting review — findings will be posted here when done. |
| ucs_offsetof(ucs_rcache_config_t, purge_on_fork), UCS_CONFIG_TYPE_BOOL}, | ||
|
|
||
| {"RCACHE_MERGE_ADJACENT", "n", "Merge adjacent registration cache regions", | ||
| {"RCACHE_MERGE_ADJACENT", "y", "Merge adjacent registration cache regions", |
There was a problem hiding this comment.
for host memory ucp_mem_rcache_can_merge_cb() returns 1 regardless of the underlying allocation, so two unrelated adjacent buffers can become one region, and freeing one of them invalidates the registration of the other. was this measured on host workloads with mixed buffer lifetimes, or only on the merge-friendly case?
| ucs_offsetof(ucs_rcache_config_t, purge_on_fork), UCS_CONFIG_TYPE_BOOL}, | ||
|
|
||
| {"RCACHE_MERGE_ADJACENT", "n", "Merge adjacent registration cache regions", | ||
| {"RCACHE_MERGE_ADJACENT", "y", "Merge adjacent registration cache regions", |
There was a problem hiding this comment.
minor: now that this is the default, modify_config("RCACHE_MERGE_ADJACENT", "y") in test_ucp_rcache_merge is a no-op and nothing covers the disabled path. can we add a variant with n there?
|
🤖 CI Triage Agent — TL;DR: The job never built anything — it died in the Azure Pipelines "Initialize containers" step because Full analysisSummary: Build Root cause: Infrastructure/Docker-state inconsistency on the build agent. The log shows Implicated commit: unknown — not a code regression; commit 31921df / PR #12267 code was never compiled or executed in this build. File: unknown (failure is in the Azure agent container-initialization step, before any repo file is used; pipeline definition: Suggested fix: Re-run the failed job — this class of failure is transient. If it recurs on Related: #12094 (CI: Jenkins integration testing) — only loosely related CI infrastructure work; no existing issue tracks this specific Docker |
What?
Default to merging rcache regions. Opt out available by setting
UCX_RCACHE_MERGE_ADJACENT=n.Why?