Skip to content

UCM: Don't call ucs_status_string() from UCM modules #12228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvegas1 merged 2 commits into from
Nov 9, 2026
+26 −6
Merged

UCM: Don't call ucs_status_string() from UCM modules #12228

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5332c84
UCM/ROCM: Don't call ucs_status_string() from libucm_rocm
ankith117 Nov 3, 2026
3f99905
UCM: Don't call ucs_status_string() from UCM modules
ankith117 Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/ucm/rocm/rocmmem.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,15 +243,14 @@ static ucs_status_t ucm_rocmmem_install(int events)
if (installed_hooks & UCM_GPU_HOOK_MODES_MASK) {
status = UCS_OK;
if ((bistro_status != UCS_OK) || (reloc_status != UCS_OK)) {
ucm_warn("rocm hooks installed with one mechanism only (bistro: %s, "
"reloc: %s)", ucs_status_string(bistro_status),
ucs_status_string(reloc_status));
Comment thread
ankith117 marked this conversation as resolved.
Resolved
ucm_warn("rocm hooks installed with one mechanism only (bistro: %d, "
"reloc: %d)", bistro_status, reloc_status);
Comment thread
ankith117 marked this conversation as resolved.
Resolved
} else {
ucm_info("rocm hooks are ready");
}
} else {
status = (bistro_status != UCS_OK) ? bistro_status : reloc_status;
ucm_diag("failed to install rocm hooks: %s", ucs_status_string(status));
ucm_diag("failed to install rocm hooks: status %d", status);
Comment thread
tvegas1 marked this conversation as resolved.
Resolved
Comment thread
ankith117 marked this conversation as resolved.
Resolved
}

pthread_mutex_unlock(&install_mutex);
Expand Down