Skip to content

UCT/CUDA/CUDA_IPC: Release unused cache entry at rkey release - v1.23.x - #12190

Merged
ofirfarjun7 merged 1 commit into
openucx:v1.23.xfrom
rakhmets:topic/cuda-ipc-cache-release-unused-1.23
Oct 29, 2026
Merged

ofirfarjun7 merged 1 commit into
openucx:v1.23.xfrom
rakhmets:topic/cuda-ipc-cache-release-unused-1.23

Conversation

@rakhmets

Copy link
Copy Markdown
Contributor

What?

Release unused cache entry at rkey release.

Cherry-picked #12108

@rakhmets
rakhmets marked this pull request as ready for review October 28, 2026 13:12
@svc-nvidia-pr-review

Copy link
Copy Markdown

🤖 Starting review — findings will be posted here when done.

Comment thread src/uct/cuda/cuda_ipc/cuda_ipc_md.c Resolved
Comment thread src/ucp/core/ucp_rkey.h Resolved
Comment thread src/ucp/core/ucp_rkey.c Resolved
Comment thread src/uct/cuda/cuda_ipc/cuda_ipc_cache.c Resolved
Comment thread src/uct/api/v2/uct_v2.h Resolved
Comment thread test/mpi/test_ucp_rkey_destroy.c Resolved
@svc-nvidia-pr-review

Copy link
Copy Markdown

test/mpi/test_ucp_rkey_destroy.c

Coverage gap: test_ucp_rkey_destroy is explicitly not run in CI (see contrib/test_jenkins.sh:925, "they fail on the CI GPU hosts"), so this change has no automated coverage, and test/gtest/uct/cuda/test_cuda_ipc_md.cc has no case for the new flag. Can we add a gtest there that unpacks with UCT_RKEY_UNPACK_FLAG_FREE_UNUSED_MAPPING and checks the cache region is gone after uct_rkey_release?

@svc-ucx

svc-ucx commented Oct 29, 2026

Copy link
Copy Markdown

🤖 CI Triage Agent — UCX PR · commit 941a6250

Summary: Unable to fetch logs — cannot diagnose without them.
Root cause: Unknown — log access failed.
Implicated commit: unknown
File: unknown
Suggested fix: Provide a direct link to the failed build log in a follow-up comment.
Log fetch attempts:

  • fetch_azure_logs({'build_url': 'https://dev.azure.com/ucfconsort/0b36e3f0-8ab9-4a48-b68b-[REDACTED:Hex High Entropy String]/_build/results?buildId=141231'}) → [fetch_azure_logs ERROR: failed job has no log entry in timeline for build 141231]
  • fetch_jenkins_stages({'job': 'UCX PR', 'build': 141231}) → [fetch_jenkins_stages ERROR] build URL names Jenkins controller 'https://dev.azure.com/ucfconsort/0b36e3f0-8ab9-4a48-b68b-[REDACTED:Hex High Entropy String]/_build/results?buildId=141231', but this deployment is configured for 'https://nbuprod.blsm.nvidia.com/nb
  • fetch_jenkins_logs({'job': 'UCX PR', 'build': 141231}) → [fetch_jenkins_logs ERROR] build URL names Jenkins controller 'https://dev.azure.com/ucfconsort/0b36e3f0-8ab9-4a48-b68b-[REDACTED:Hex High Entropy String]/_build/results?buildId=141231', but this deployment is configured for 'https://nbuprod.blsm.nvidia.com/nbu-
  • fetch_azure_logs({'build_url': 'https://dev.azure.com/ucfconsort/ucx/_build/results?buildId=141231'}) → [fetch_azure_logs ERROR: failed job has no log entry in timeline for build 141231]
  • fetch_azure_logs({'build_url': 'https://dev.azure.com/ucfconsort/0b36e3f0-8ab9-4a48-b68b-[REDACTED:Hex High Entropy String]/_build/results?buildId=141231&view=logs'}) → [fetch_azure_logs ERROR: failed job has no log entry in timeline for build 141231]
  • fetch_test_server_logs({'node': 'dev.azure.com', 'job': 'UCX PR 141231'}) → [fetch_test_server_logs ERROR] dev.azure.com/UCX PR 141231: FileNotFoundError: [Errno 2] No such file or directory: '/home/ci/.ssh/id_rsa'

🛡️ This comment had 1 potential secret(s) redacted (Hex High Entropy String). See request_id 4bcf8841-acf9-41de-9f1e-480a2afbe645 in the triage console for the audit trail.

@ofirfarjun7
ofirfarjun7 enabled auto-merge (squash) October 29, 2026 11:48
@ofirfarjun7
ofirfarjun7 merged commit 5ee910c into openucx:v1.23.x Oct 29, 2026
162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants