Skip to content

UCT/GDAKI: Restore "Check for HCA reachability like rc_mlx5 (#11781)" #11945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofirfarjun7 merged 1 commit into from
Sep 14, 2026
Merged

UCT/GDAKI: Restore "Check for HCA reachability like rc_mlx5 (#11781)" #11945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/uct/ib/mlx5/gdaki/gdaki.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,7 +1058,7 @@ static uct_rc_iface_ops_t uct_rc_gdaki_internal_ops = {
.ep_query = (uct_ep_query_func_t)ucs_empty_function_return_unsupported,
.ep_invalidate = (uct_ep_invalidate_func_t)ucs_empty_function_return_unsupported,
.ep_connect_to_ep_v2 = uct_rc_gdaki_ep_connect_to_ep_v2,
.iface_is_reachable_v2 = (uct_iface_is_reachable_v2_func_t)ucs_empty_function_return_one_int,
.iface_is_reachable_v2 = uct_ib_iface_is_reachable_v2,

@svc-nvidia-pr-review svc-nvidia-pr-review Sep 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gda's iface address only carries the RC address-type constant, so a peer with a different NUM_CHANNELS is still reported reachable and uct_rc_gdaki_ep_connect_to_ep_v2 then reads iface->num_channels QPNs out of a shorter remote ep address. can we compare num_channels here too, the way rc_mlx5 compares the TM address type before delegating?

.ep_is_connected = uct_rc_gdaki_ep_is_connected,
.ep_get_device_ep = uct_rc_gdaki_ep_get_device_ep,
.ep_outstanding_purge = (uct_ep_outstanding_purge_func_t)ucs_empty_function_return_unsupported
Expand Down
1 change: 1 addition & 0 deletions test/gtest/uct/test_uct_iface.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,3 +98,4 @@ UCS_TEST_P(test_uct_iface, is_reachable)
}

@svc-nvidia-pr-review svc-nvidia-pr-review Sep 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new rc_gda case only exercises self-address reachability plus random-address rejection; it does not cover a real cross-node gda pair or a RoCE-vs-IB link-layer mismatch. That matches what the existing IB transports get from this fixture, so no extra test is warranted.

@svc-nvidia-pr-review svc-nvidia-pr-review Sep 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rc_gda/test_uct_iface.is_reachable silently registers zero tests on machines without GDA support (no active CUDA primary context, no peermem/DMABUF), so the effective validation depends on the GDA CI job in contrib/test_jenkins.sh actually running gtest.


UCT_INSTANTIATE_TEST_CASE(test_uct_iface)
_UCT_INSTANTIATE_TEST_CASE(test_uct_iface, rc_gda)