Repository navigation
Conversation
If check_events_do could not arm the iface (returned BUSY), we can hang forever in ucp_worker_wait because one of the inactive ifaces is not armed to be re-activated and trigger wakeup via worker->eventfd channel.
|
🤖 Starting review — findings will be posted here when done. |
| } | ||
| } | ||
|
|
||
| /* FIXME proto_select could get invalidated by adding rkey config */ |
There was a problem hiding this comment.
what's the plan for this FIXME? if proto_select can really be invalidated by adding an rkey config while a cached pointer is live, that's a use-after-realloc, not just a note. can we open an issue and reference it here, or is this already handled by ucp_proto_select_cache_reset()?
There was a problem hiding this comment.
will fix it as a separate PR for master branch
| EXPECT_FALSE(ep_config->proto_init_flags & | ||
| UCP_EP_PROTO_SHORT_INITIALIZED); | ||
|
|
||
| /* No protocol can be cached while the initialization flag is clear */ |
There was a problem hiding this comment.
minor: the comment says "No protocol can be cached while the initialization flag is clear", but the flag being clear is checked just above; here we're asserting the flag gets set by the first send. maybe reword to "short init is deferred until the first send".
|
Style note (non-blocking): The enriched |
|
🤖 CI Triage Agent — TL;DR: This is not a code failure — the Azure agent on Full analysisSummary: The Root cause: Infrastructure, not the PR. The log shows continuous activity from 13:20:32 to 13:20:48 (largest inter-line gap < 0.5 s, so no hang and no wall-clock timeout), then:
The self-hosted agent ( A secondary, corroborating environment smell: on this RoCE worker the first configure pass detected no verbs support — Implicated commit: none — no UCX commit is implicated; the failure is agent/host-level. File: N/A (job cancelled inside Suggested fix:
Related: none (no matching issue found; the search hits for the agent-shutdown string were unrelated PRs).
|
|
Merged as #12035 as we missed that one. |
Why
Backport #11817 to v1.23.x branch