Repository navigation
UCP/PROTO: Keep latency singles off lanes beyond the fast-path array - #11808
Merged
roiedanino merged 1 commit intoAug 25, 2026
Merged
roiedanino merged 1 commit into
roiedanino merged 1 commit into
Conversation
Progress for AM/TAG/RMA/AMO single protos uses ucp_ep_get_fast_lane(), which cannot index lanes stored in ep->ext. Exclude those lanes at probe time so BW/multi protocols cover them until failover recovery.
roiedanino
reviewed
Aug 23, 2026
| .super.flags = flags | UCP_PROTO_COMMON_INIT_FLAG_SINGLE_FRAG | | ||
| UCP_PROTO_COMMON_INIT_FLAG_CAP_SEG_SIZE, | ||
| .super.exclude_map = 0, | ||
| .super.exclude_map = ~UCP_MAX_FAST_PATH_LANES_MASK, |
Contributor
There was a problem hiding this comment.
amo_sw is lane_type = AM. If all AM lanes < 5 have failed and the only
survivor is a promoted am_bw lane >= 5, AMO now has no protocol at all instead
of using that lane. Clean error or fatal?
Contributor
Author
There was a problem hiding this comment.
the same as fast path AM, SW AMO accesses only fast lane:
Line 80 in 78529b0
roiedanino
approved these changes
Aug 23, 2026
roiedanino
left a comment
roiedanino
left a comment
Contributor
There was a problem hiding this comment.
Approved, consider adding ft test forcing am_lane past first 5
Contributor
Author
This path will be enabled automatically once we enable ERR_MODE_FAILOVER for AM-short and AM-bcopy protocols. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Exclude slow lanes from fast protocols selection
Why?
Progress for AM/TAG/RMA/AMO single protos uses ucp_ep_get_fast_lane(), which cannot index lanes stored in ep->ext.
How?
Exclude those lanes at probe time so BW/multi protocols cover them until failover recovery.