Skip to content

UCP/PROTO: Generalize lane SGL zcopy count for put and get - #11765

Merged
brminich merged 1 commit into
openucx:masterfrom
michal-shalev:ucp-proto-multi-sgl-count
Aug 14, 2026
Merged

brminich merged 1 commit into
openucx:masterfrom
michal-shalev:ucp-proto-multi-sgl-count

Conversation

@michal-shalev

Copy link
Copy Markdown
Contributor

What?

Rename max_put_sgl_zcopy_count to max_sgl_zcopy_count in the multi-lane protocol private data, and query the matching UCT attribute for put or get.

Why?

Preparation for the SGL get offload protocols, which need the same per-lane limit.

How?

A protocol is either put or get, so the direction is decided once from its tl_v2_cap_flags. No functional change.

@michal-shalev
michal-shalev requested a review from tvegas1 August 13, 2026 07:50

v2_cap_flags = params->first.tl_v2_cap_flags |
params->middle.tl_v2_cap_flags;
sgl_is_put = v2_cap_flags & UCT_IFACE_FLAG_V2_PUT_SGL_ZCOPY;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe sgl_has_put

@brminich
brminich merged commit 0a5fba2 into openucx:master Aug 14, 2026
161 checks passed
@michal-shalev
michal-shalev deleted the ucp-proto-multi-sgl-count branch August 16, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants