UCP/API: docs - user can modify buffer after calling ucp_atomic_op_nbx as its being packed (copied)#11126
Merged
gleon99 merged 3 commits intoopenucx:masterfrom Feb 12, 2026
Merged
Conversation
…x as its being packed (copied) Signed-off-by: Roie Danino <rdanino@nvidia.com>
yosefe
reviewed
Jan 20, 2026
Signed-off-by: Roie Danino <rdanino@nvidia.com>
yosefe
reviewed
Jan 20, 2026
Signed-off-by: Roie Danino <rdanino@nvidia.com>
Contributor
Author
|
@yosefe I guess we can merge this one? |
gleon99
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Modified the note in
ucp_atomic_op_nbx, removing the user limitation of modifying the buffer after calling the APIWhy?
The buffer value is being packed during the call, and therefore, there's no problem modifying/freeing it before completion.