Repository navigation
UCT/GDA: Use gpunetio submodule - #11122
Merged
Merged
Conversation
Artemy-Mellanox
force-pushed
the
topic/gpunetio-use
branch
from
January 18, 2026 07:17
ab513f9 to
89ad9e1
Compare
yosefe
reviewed
Jan 18, 2026
Artemy-Mellanox
force-pushed
the
topic/gpunetio-use
branch
from
January 18, 2026 15:53
89ad9e1 to
5dfed4b
Compare
yosefe
reviewed
Jan 18, 2026
Artemy-Mellanox
force-pushed
the
topic/gpunetio-use
branch
from
January 25, 2026 10:10
2621db8 to
432a4ba
Compare
ofirfarjun7
reviewed
Feb 8, 2026
Artemy-Mellanox
force-pushed
the
topic/gpunetio-use
branch
from
February 11, 2026 13:07
ccf4a2b to
e79b87a
Compare
jeynmann
reviewed
Feb 11, 2026
| #include <ucp/api/device/ucp_host.h> | ||
| #include <ucs/sys/device_code.h> | ||
|
|
||
| #if defined(__NVCC__) && !defined(__builtin_ia32_prefetch) |
Contributor
There was a problem hiding this comment.
Maybe add into a common header for this workaround to avoid multiple definitions?
tvegas1
reviewed
Feb 11, 2026
tvegas1
reviewed
Feb 16, 2026
yosefe
reviewed
Feb 17, 2026
| #include <doca_gpunetio_dev_verbs_qp.cuh> | ||
| #include <infiniband/mlx5dv.h> /* TODO add to gpunetio */ | ||
| #include <cuda.h> /* TODO add to gpunetio */ | ||
| #include <uct/ib/mlx5/gdaki/device/doca_gpunetio_dev_verbs_qp.cuh> |
Member
There was a problem hiding this comment.
can we include "device/doca_gpunetio_dev_verbs_qp.cuh" ?
tvegas1
reviewed
Feb 24, 2026
tvegas1
previously approved these changes
Feb 25, 2026
yosefe
reviewed
Feb 26, 2026
| #include <doca_gpunetio_dev_verbs_qp.cuh> | ||
| #include <infiniband/mlx5dv.h> /* TODO add to gpunetio */ | ||
| #include <cuda.h> /* TODO add to gpunetio */ | ||
| #include "device/doca_gpunetio_dev_verbs_qp.cuh" |
Artemy-Mellanox
force-pushed
the
topic/gpunetio-use
branch
2 times, most recently
from
March 2, 2026 09:54
76f2c3b to
903c544
Compare
Artemy-Mellanox
force-pushed
the
topic/gpunetio-use
branch
from
March 2, 2026 16:24
903c544 to
1dd18a1
Compare
yosefe
requested changes
Mar 2, 2026
Comment on lines
+204
to
205
| #if HAVE_DECL_MLX5DV_UMEM_MASK_DMABUF | ||
| struct mlx5dv_devx_umem_in umem_in = {}; |
Member
There was a problem hiding this comment.
can we unite some common code with uct_gdaki_check_umem_dmabuf?
yosefe
approved these changes
Mar 7, 2026
| uct_elem, comp); | ||
| result.producer_index = 0; | ||
| result.ready_index = 0; | ||
| #if HAVE_MLX5_DV |
Member
There was a problem hiding this comment.
we should remove this code altogether (why need GDA specific code in UCP level test kernel?)
but can be in next PR
| #include <ucp/api/device/ucp_device_impl.h> | ||
| #include <ucs/debug/log.h> | ||
| #include <common/cuda.h> | ||
| #include <cuda.h> |
Member
There was a problem hiding this comment.
move this include to common/cuda.h
| #include <uct/ib/mlx5/gdaki/gdaki.cuh> | ||
| #if __has_include(<uct/ib/mlx5/gdaki/gdaki.cuh>) && __has_include(<infiniband/mlx5dv.h>) | ||
| # include <uct/ib/mlx5/gdaki/gdaki.cuh> | ||
| # define UCT_RC_MLX5_GDA_SUPPORTED 1 |
Member
There was a problem hiding this comment.
I'd propose unified naming:
UCT_TL_RC_MLX5_GDA
UCT_TL_RC_MLX5_GDA_ENABLE
UCT_HAVE_TL_RC_MLX5_GDA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.